[build] Use bzlmod for development and testing #22269
Conversation
jwnimmer-tri
added
priority: low
status: do not merge
status: do not review
release notes: feature
jwnimmer-tri
force-pushed
the
bzlmod-migration
branch
from
e1b8072 to
c0a40f0
Compare
jwnimmer-tri
force-pushed
the
bzlmod-migration
branch
2 times, most recently
from
bee78bc to
6203abe
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jwnimmer-tri
force-pushed
the
bzlmod-migration
branch
2 times, most recently
from
9be0ffc to
db67248
Compare
jwnimmer-tri
changed the title
jwnimmer-tri
force-pushed
the
bzlmod-migration
branch
from
db67248 to
c57040f
Compare
jwnimmer-tri
force-pushed
the
bzlmod-migration
branch
2 times, most recently
from
b01d0c4 to
6bc63ce
Compare
jwnimmer-tri
force-pushed
the
bzlmod-migration
branch
2 times, most recently
from
06e6f1b to
a5e94c2
Compare
There was a problem hiding this comment.
Alright, this monster is ready to begin feature review. All of the prep PRs ahead of it have landed.
+@rpoyner-tri to for feature review, please. There is no hurry here, sometime later next week is fine.
Reviewed 5 of 6 files at r2, 7 of 13 files at r3, 22 of 23 files at r4, 10 of 10 files at r5, 6 of 6 files at r6, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers
a discussion (no related file):
Working
For sanity / safety in terms of merge sequencing, I'll block here to allow #22305 to reach master first.
jwnimmer-tri
added
release notes: none
In other words, Drake Developers will now be using bzlmod by default. (CMake installs were already using it.) Users who consume Drake as a bazel external must still use workspace mode (no bzlmod). Even though Drake now uses bzlmod for developers, it is not yet possible for downstream projects to consume Drake as a bzlmod module; that remains future work. The main change required for bzlmod here is that our module name in runfiles is "_main" now instead of "drake", which mostly affects some linters and tests that were hard-coded. More generally, there is now a concept of "repo mapping" where module names in a MODULE.bazel file are projected to unique names in runfiles, to allow for multiple copies of modules to co-exist. This means that a runfiles lookup must not only specify the path it's looking for, but from _whose point of view_ that path is coming from. * common: Adjust FindRunfile to know about source_repository. When none is given and we're seeking a drake runfile, supply the right "point of view" string automatically. * resource_tool_test: Loosen test condition to be only the file basename. * unittest_main: Adjust our source file scan to allow for either the bzlmod or workspace spelling of the test program. (The old workspace spelling would only be used by downstream projects.) * tools: Adjust find_all_sources scan for .bazelproject to check against the realpath instead of the runfiles path.
jwnimmer-tri
force-pushed
the
bzlmod-migration
branch
from
a5e94c2 to
121152c
Compare
There was a problem hiding this comment.
Reviewed 7 of 7 files at r7, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
For sanity / safety in terms of merge sequencing, I'll block here to allow #22305 to reach master first.
Done and rebased.
Towards #20731. See the commit message for details.
Given that there are now two "modes" for how Drake declares its externals (workspace vs bzlmod), it's important to consider how we achieve good CI coverage for both.
(1) As of this PR, Bzlmod mode will be tested in our main CI since it is on by default for all first-party Bazel and CMake builds -- pre-merge jobs will run it, as will Continuous, Nightly, Packaging, Wheel, etc.
(2) Workspace mode will only be tested nightly by the drake_bazel_external_legacy example downstream project. For PRs with acute risk, we can run that project by hand to check for any failures. I anticipate this will be good enough, but if we find lots of bugs leaking through to post-merge failures, we can revisit our CI matrix.
This change is