-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/scmi 124851 [Domain models initiative] validate method rules #1788
Open
aleixadevinta
wants to merge
5
commits into
master
Choose a base branch
from
feat/SCMI-124851_validate_method_rules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9dddf73
feat(packages/eslint-plugin-sui): create lint rule
aleixferr 0567d85
feat(packages/sui-lint): add lint rule to config
aleixferr ec0e093
feat(packages/eslint-plugin-sui): check if file is in VO/Entity folder
aleixferr 9061e9d
feat(packages/eslint-plugin-sui): check if file is in VO/Entity folder
aleixferr 69c122b
feat(packages/eslint-plugin-sui): check if keys exists
aleixferr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
/** | ||
* @fileoverview ensure domain model have a validate method | ||
*/ | ||
'use strict' | ||
|
||
const dedent = require('string-dedent') | ||
const path = require('path') | ||
|
||
// ------------------------------------------------------------------------------ | ||
// Rule Definition | ||
// ------------------------------------------------------------------------------ | ||
|
||
/** @type {import('eslint').Rule.RuleModule} */ | ||
module.exports = { | ||
meta: { | ||
type: 'suggestion', | ||
docs: { | ||
description: 'Ensure domain models have a validate method', | ||
recommended: false, | ||
url: 'https://github.mpi-internal.com/scmspain/es-td-agreements/blob/master/30-Frontend/00-agreements' | ||
}, | ||
fixable: null, | ||
schema: [], | ||
messages: { | ||
missingValidateMethod: dedent` | ||
If your class is a domain model (Value Object or Entity), you have to define a 'static validate' method. | ||
`, | ||
missingValidateMethodStatic: dedent` | ||
The validate method should be static. | ||
` | ||
} | ||
}, | ||
|
||
create(context) { | ||
const filePath = context.getFilename() | ||
const relativePath = path.relative(context.getCwd(), filePath) | ||
|
||
// Check if the file is inside requierd folders (useCases, services, repositories, ...) | ||
const valueObjectPattern = /valueObjects|valueobjects|ValueObjects|Valueobjects/i | ||
const isValueObjectPath = valueObjectPattern.test(relativePath) | ||
|
||
const entityPattern = /entity|Entity/i | ||
const isEntityPath = entityPattern.test(relativePath) | ||
|
||
return { | ||
ClassDeclaration(node) { | ||
const validateMethod = node.body?.body?.find(i => i.key?.name === 'validate') | ||
|
||
const className = node.id?.name ?? '' | ||
|
||
const allowedWords = ['VO', 'ValueObject', 'Entity'] | ||
|
||
const isDomainModelName = allowedWords.some(allowWord => className.includes(allowWord)) | ||
|
||
if (!isDomainModelName && !isValueObjectPath) return | ||
if (!isDomainModelName && !isEntityPath) return | ||
|
||
if (!validateMethod) | ||
return context.report({ | ||
node: node.id, | ||
messageId: 'missingValidateMethod' | ||
}) | ||
|
||
const hasStaticModifier = validateMethod.static | ||
|
||
if (!hasStaticModifier) | ||
return context.report({ | ||
node: validateMethod, | ||
messageId: 'missingValidateMethodStatic' | ||
}) | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this comment or remove it 👀