Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DynamicsModelTpl separate from StageFunctionTpl class hierarchy #229

Merged
merged 24 commits into from
Oct 10, 2024

Conversation

ManifoldFR
Copy link
Member

Also:

  • remove clone.hpp, version.hpp headers

Merge after #226

Progress on #208 and #79

@ManifoldFR ManifoldFR added the api label Oct 9, 2024
@ManifoldFR ManifoldFR requested a review from edantec October 9, 2024 20:29
@ManifoldFR ManifoldFR force-pushed the topic/remove-dynamics-from-function-hierarchy branch 2 times, most recently from 7b67c8d to 46686e5 Compare October 10, 2024 13:30
@ManifoldFR ManifoldFR force-pushed the topic/remove-dynamics-from-function-hierarchy branch from 46686e5 to 5144c30 Compare October 10, 2024 14:15
Copy link
Collaborator

@edantec edantec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are one or two details that bother me bu otherwise good job!

include/aligator/core/dynamics.hxx Show resolved Hide resolved
include/aligator/core/dynamics.hpp Show resolved Hide resolved
include/aligator/core/traj-opt-problem.hxx Show resolved Hide resolved
include/aligator/core/traj-opt-problem.hxx Show resolved Hide resolved
@edantec edantec merged commit e92a768 into devel Oct 10, 2024
35 checks passed
@edantec edantec deleted the topic/remove-dynamics-from-function-hierarchy branch October 10, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants