-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the installer and uninstaller #84
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I've added the |
@@ -15,11 +15,11 @@ Make sure that the operating system meets the following prerequisites | |||
|
|||
- **System-wide** | |||
```bash | |||
bash <(curl -s "https://raw.githubusercontent.com/amber-lang/amber/master/setup/install.sh") | |||
bash <(curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have --
following the bash
command elsewhere, I'm guessing so that --user
is passed to the downloaded install script, rather than bash
itself. Consider adding here for consistency:
bash -- <(curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you tested the command? because we had issues in the past and I found that this command works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that curl
successfully downloads the script:
$ curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh" | head
#!/usr/bin/env bash
# Written in [Amber](https://amber-lang.com/)
# version: 0.4.0-alpha
# date: 2024-12-21 20:03:44
file_exists__33_v0() {
local path=$1
[ -f "${path}" ] ;
__AS=$?;
if [ $__AS != 0 ]; then
I did not try installing from scratch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is not just downloading but executing, I did the same mistake and I had to change again the command.
Updates the installer and uninstaller in 0.4.0 with the new installer generated by CI