Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the installer and uninstaller #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ph0enixKM
Copy link
Member

@Ph0enixKM Ph0enixKM commented Dec 25, 2024

Updates the installer and uninstaller in 0.4.0 with the new installer generated by CI

@Ph0enixKM Ph0enixKM linked an issue Dec 25, 2024 that may be closed by this pull request
@Ph0enixKM Ph0enixKM requested a review from Mte90 December 25, 2024 11:21
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amber-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 11:21am

@Ph0enixKM
Copy link
Member Author

I've added the -L flag to the curl, because the URL redirects

@@ -15,11 +15,11 @@ Make sure that the operating system meets the following prerequisites

- **System-wide**
```bash
bash <(curl -s "https://raw.githubusercontent.com/amber-lang/amber/master/setup/install.sh")
bash <(curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have -- following the bash command elsewhere, I'm guessing so that --user is passed to the downloaded install script, rather than bash itself. Consider adding here for consistency:

bash -- <(curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you tested the command? because we had issues in the past and I found that this command works.

Copy link
Contributor

@hdwalters hdwalters Dec 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that curl successfully downloads the script:

$ curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh" | head
#!/usr/bin/env bash
# Written in [Amber](https://amber-lang.com/)
# version: 0.4.0-alpha
# date: 2024-12-21 20:03:44

file_exists__33_v0() {
    local path=$1
     [ -f "${path}" ] ;
    __AS=$?;
if [ $__AS != 0 ]; then

I did not try installing from scratch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is not just downloading but executing, I did the same mistake and I had to change again the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update (un)installer URL
3 participants