Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the installer and uninstaller #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update the installer and uninstaller #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/0.4.0-alpha/getting_started/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ Make sure that the operating system meets the following prerequisites

- **System-wide**
```bash
bash <(curl -s "https://raw.githubusercontent.com/amber-lang/amber/master/setup/install.sh")
bash <(curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have -- following the bash command elsewhere, I'm guessing so that --user is passed to the downloaded install script, rather than bash itself. Consider adding here for consistency:

bash -- <(curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you tested the command? because we had issues in the past and I found that this command works.

Copy link
Contributor

@hdwalters hdwalters Dec 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that curl successfully downloads the script:

$ curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh" | head
#!/usr/bin/env bash
# Written in [Amber](https://amber-lang.com/)
# version: 0.4.0-alpha
# date: 2024-12-21 20:03:44

file_exists__33_v0() {
    local path=$1
     [ -f "${path}" ] ;
    __AS=$?;
if [ $__AS != 0 ]; then

I did not try installing from scratch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is not just downloading but executing, I did the same mistake and I had to change again the command.

```
- **Local-user**
```bash
bash -- <(curl -s "https://raw.githubusercontent.com/amber-lang/amber/master/setup/install.sh") --user
bash -- <(curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh") --user
```
- **Package manager**

Expand Down Expand Up @@ -78,5 +78,5 @@ If these tools are available on your system, they will be executed at the end of
You can uninstall Amber any time. To do this you can simply run the following code snippet.

```sh
bash -- <(curl -s "https://raw.githubusercontent.com/amber-lang/amber/master/setup/uninstall.sh")
bash -- <(curl -sL "https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/uninstall.sh")
```