MoMAGIC Ad Network - Vendor Registration #39898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
reviewed
Mar 20, 2024
|
@mmprebid could you re-push the code to re-trigger circieCI |
powerivq
requested changes
Mar 21, 2024
powerivq
requested changes
Mar 27, 2024
|
@mmprebid thank you! added two more comments and it should be good then. |
powerivq
requested changes
Mar 27, 2024
powerivq
requested changes
Mar 28, 2024
powerivq
requested changes
Apr 8, 2024
powerivq
approved these changes
Apr 9, 2024
|
@mmprebid Thanks. Looks good now, but unfortunately (I have tried a few times), the build is not running. I do not know if it is because of the branch name |
|
closing this PR in favor of the new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ New Vendor
MoMAGIC Ad Network is an all-in-one platform that help businesses to generate revenue through Advertisements. MoMAGIC supports advertising technologies like RTB (Real Time Bidding), Header Bidding, Google Ad Manager Based deployment and simplified JS Implementations. We help provide various kinds of Ad Format support ranging from simple banner, video to instream video and interactive banner/video Ads.
This PR adds and integrates the MoMAGIC Ad Network to the amp vendor list, using the tag amp-ad.