-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MoMAGIC Ad Network - Vendor Registration #39956
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mmprebid Circle CI is not running for this. You might need to combine all commits into a single one, rather than having 21 commits. Let's see if that works. |
Hey @alanorozco! These files were changed:
Hey @danielrozenberg! These files were changed:
Hey @ampproject/wg-caching! These files were changed:
|
I am closing this PR. I created one for you at #39963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@powerivq
As Suggested on Previous Open PR - #39898, We are creating this PR with new branch MASTER with the same code. Please approve accordingly
✨ New Vendor
MoMAGIC Ad Network is an all-in-one platform that help businesses to generate revenue through Advertisements. MoMAGIC supports advertising technologies like RTB (Real Time Bidding), Header Bidding, Google Ad Manager Based deployment and simplified JS Implementations. We help provide various kinds of Ad Format support ranging from simple banner, video to instream video and interactive banner/video Ads.
This PR adds and integrates the MoMAGIC Ad Network to the amp vendor list, using the tag amp-ad.