Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoMAGIC Ad Network - Vendor Registration #39956

Closed
wants to merge 49 commits into from
Closed

MoMAGIC Ad Network - Vendor Registration #39956

wants to merge 49 commits into from

Conversation

mmprebid
Copy link
Contributor

@powerivq
As Suggested on Previous Open PR - #39898, We are creating this PR with new branch MASTER with the same code. Please approve accordingly

✨ New Vendor
MoMAGIC Ad Network is an all-in-one platform that help businesses to generate revenue through Advertisements. MoMAGIC supports advertising technologies like RTB (Real Time Bidding), Header Bidding, Google Ad Manager Based deployment and simplified JS Implementations. We help provide various kinds of Ad Format support ranging from simple banner, video to instream video and interactive banner/video Ads.

This PR adds and integrates the MoMAGIC Ad Network to the amp vendor list, using the tag amp-ad.

@powerivq
Copy link
Contributor

powerivq commented Apr 11, 2024

@mmprebid Circle CI is not running for this. You might need to combine all commits into a single one, rather than having 21 commits. Let's see if that works.

@erwinmombay erwinmombay requested review from powerivq and removed request for calebcordry April 12, 2024 17:20
Copy link

amp-owners-bot bot commented Apr 16, 2024

Hey @alanorozco! These files were changed:

build-system/tasks/storybook/env/amp/package-lock.json
build-system/tasks/storybook/env/amp/package.json
build-system/tasks/storybook/env/preact/package-lock.json
build-system/tasks/storybook/env/preact/package.json
build-system/tasks/storybook/package-lock.json
build-system/tasks/storybook/package.json

Hey @danielrozenberg! These files were changed:

build-system/tasks/visual-diff/package-lock.json
build-system/tasks/visual-diff/package.json

Hey @ampproject/wg-caching! These files were changed:

validator/BUILD
validator/build.py
validator/cpp/engine/BUILD
validator/cpp/engine/scripts/BUILD
validator/cpp/engine/wasm/BUILD
validator/cpp/htmlparser/BUILD
validator/cpp/htmlparser/bin/BUILD
validator/cpp/htmlparser/css/BUILD
validator/cpp/htmlparser/data/BUILD
validator/cpp/htmlparser/grammar/BUILD
validator/cpp/htmlparser/json/BUILD
validator/cpp/htmlparser/validators/BUILD
+8 more

@powerivq
Copy link
Contributor

I am closing this PR. I created one for you at #39963

@powerivq powerivq closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants