-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBC Packet Forward Middleware #4082
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4082 +/- ##
==========================================
- Coverage 74.46% 74.42% -0.05%
==========================================
Files 342 343 +1
Lines 107773 108185 +412
==========================================
+ Hits 80257 80512 +255
- Misses 27516 27673 +157 ☔ View full report in Codecov by Sentry. |
0cf7093
to
dc3950c
Compare
(before rebase/history cleanup: dc3950c) |
dc3950c
to
c9c8d57
Compare
c9c8d57
to
7b6135d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left trivial comments.
7b6135d
to
6d01475
Compare
6d01475
to
08669c1
Compare
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
08669c1
to
d50cccd
Compare
(rebased on latest |
Co-authored-by: Jacob Turner <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
d50cccd
to
878ca57
Compare
Describe your changes
Integrate with the Packet Forward Middleware code. Requires an
ibc-rs
fork, in order to support asynchronous IBC packet acknowledgements.NOTE: The code in the links above should also be reviewed.
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo