Merge pull request #257 from rex4539/typos #534
Annotations
3 errors and 39 warnings
use of a fallible conversion when an infallible one could be used:
taiga_halo2/src/circuit/vp_circuit.rs#L150
error: use of a fallible conversion when an infallible one could be used
--> taiga_halo2/src/circuit/vp_circuit.rs:150:13
|
150 | val.try_into()
| ^^^^^^^^ help: use: `into`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`
|
use of a fallible conversion when an infallible one could be used:
taiga_halo2/src/circuit/vp_circuit.rs#L150
error: use of a fallible conversion when an infallible one could be used
--> taiga_halo2/src/circuit/vp_circuit.rs:150:13
|
150 | val.try_into()
| ^^^^^^^^ help: use: `into`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`
|
Clippy lint checks
Clippy had exited with the 101 exit code
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
taiga_halo2/src/resource_encryption.rs#L135
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/resource_encryption.rs:135:25
|
135 | pub fn padding(msg: &Vec<pallas::Base>) -> Self {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
135 ~ pub fn padding(msg: &[pallas::Base]) -> Self {
136 ~ let mut plaintext = msg.to_owned();
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
taiga_halo2/src/resource_encryption.rs#L135
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/resource_encryption.rs:135:25
|
135 | pub fn padding(msg: &Vec<pallas::Base>) -> Self {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
135 ~ pub fn padding(msg: &[pallas::Base]) -> Self {
136 ~ let mut plaintext = msg.to_owned();
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
taiga_halo2/src/circuit/blake2s.rs#L979
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:979:30
|
979 | pub fn word_rotate(bits: &Vec<AssignedCell<F, F>>, by: usize) -> Vec<AssignedCell<F, F>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AssignedCell<F, F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
taiga_halo2/src/circuit/blake2s.rs#L434
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:434:14
|
434 | ret: &Vec<Blake2sWord<F>>,
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Blake2sWord<F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-W clippy::ptr-arg` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
taiga_halo2/src/circuit/blake2s.rs#L979
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:979:30
|
979 | pub fn word_rotate(bits: &Vec<AssignedCell<F, F>>, by: usize) -> Vec<AssignedCell<F, F>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AssignedCell<F, F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
use of a fallible conversion when an infallible one could be used:
taiga_halo2/src/circuit/vp_circuit.rs#L150
warning: use of a fallible conversion when an infallible one could be used
--> taiga_halo2/src/circuit/vp_circuit.rs:150:13
|
150 | val.try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `Vec<Fp>` to `ValidityPredicatePublicInputs` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-W clippy::unnecessary-fallible-conversions` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_fallible_conversions)]`
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
taiga_halo2/src/circuit/blake2s.rs#L434
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:434:14
|
434 | ret: &Vec<Blake2sWord<F>>,
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Blake2sWord<F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-W clippy::ptr-arg` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`
|
use of a fallible conversion when an infallible one could be used:
taiga_halo2/src/circuit/vp_circuit.rs#L150
warning: use of a fallible conversion when an infallible one could be used
--> taiga_halo2/src/circuit/vp_circuit.rs:150:13
|
150 | val.try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `Vec<Fp>` to `ValidityPredicatePublicInputs` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-W clippy::unnecessary-fallible-conversions` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_fallible_conversions)]`
|
Nightly lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Nightly lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rustfmt:
taiga_halo2/src/circuit/vp_circuit.rs#L34
unused import: `read_base_field`
|
Rustfmt:
taiga_halo2/src/circuit/vp_examples.rs#L12
unused import: `utils::read_base_field`
|
Rustfmt:
taiga_halo2/src/merkle_tree.rs#L5
unused import: `read_base_field`
|
Rustfmt:
taiga_halo2/src/nullifier.rs#L5
unused import: `read_base_field`
|
Rustfmt:
taiga_halo2/src/resource.rs#L14
unused import: `read_base_field`
|
Rustfmt:
taiga_halo2/src/shielded_ptx.rs#L14
unused import: `crate::utils::read_scalar_field`
|
Rustfmt
`taiga_halo2` (lib) generated 6 warnings (run `cargo fix --lib -p taiga_halo2` to apply 6 suggestions)
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy lint checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Clippy lint checks
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test on ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test on ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|