Merge pull request #257 from rex4539/typos #534
Clippy (beta)
8 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 8 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.76.0-beta.7 (e8b6db725 2024-01-22)
- cargo 1.76.0-beta.7 (c84b36747 2024-01-18)
- clippy 0.1.76 (e8b6db7 2024-01-22)
Annotations
Check warning on line 135 in taiga_halo2/src/resource_encryption.rs
github-actions / Clippy (beta)
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/resource_encryption.rs:135:25
|
135 | pub fn padding(msg: &Vec<pallas::Base>) -> Self {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
135 ~ pub fn padding(msg: &[pallas::Base]) -> Self {
136 ~ let mut plaintext = msg.to_owned();
|
Check warning on line 135 in taiga_halo2/src/resource_encryption.rs
github-actions / Clippy (beta)
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/resource_encryption.rs:135:25
|
135 | pub fn padding(msg: &Vec<pallas::Base>) -> Self {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
135 ~ pub fn padding(msg: &[pallas::Base]) -> Self {
136 ~ let mut plaintext = msg.to_owned();
|
Check warning on line 979 in taiga_halo2/src/circuit/blake2s.rs
github-actions / Clippy (beta)
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:979:30
|
979 | pub fn word_rotate(bits: &Vec<AssignedCell<F, F>>, by: usize) -> Vec<AssignedCell<F, F>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AssignedCell<F, F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
Check warning on line 434 in taiga_halo2/src/circuit/blake2s.rs
github-actions / Clippy (beta)
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:434:14
|
434 | ret: &Vec<Blake2sWord<F>>,
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Blake2sWord<F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-W clippy::ptr-arg` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`
Check warning on line 979 in taiga_halo2/src/circuit/blake2s.rs
github-actions / Clippy (beta)
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:979:30
|
979 | pub fn word_rotate(bits: &Vec<AssignedCell<F, F>>, by: usize) -> Vec<AssignedCell<F, F>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AssignedCell<F, F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
Check warning on line 150 in taiga_halo2/src/circuit/vp_circuit.rs
github-actions / Clippy (beta)
use of a fallible conversion when an infallible one could be used
warning: use of a fallible conversion when an infallible one could be used
--> taiga_halo2/src/circuit/vp_circuit.rs:150:13
|
150 | val.try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `Vec<Fp>` to `ValidityPredicatePublicInputs` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-W clippy::unnecessary-fallible-conversions` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_fallible_conversions)]`
Check warning on line 434 in taiga_halo2/src/circuit/blake2s.rs
github-actions / Clippy (beta)
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:434:14
|
434 | ret: &Vec<Blake2sWord<F>>,
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Blake2sWord<F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-W clippy::ptr-arg` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`
Check warning on line 150 in taiga_halo2/src/circuit/vp_circuit.rs
github-actions / Clippy (beta)
use of a fallible conversion when an infallible one could be used
warning: use of a fallible conversion when an infallible one could be used
--> taiga_halo2/src/circuit/vp_circuit.rs:150:13
|
150 | val.try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `Vec<Fp>` to `ValidityPredicatePublicInputs` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-W clippy::unnecessary-fallible-conversions` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_fallible_conversions)]`