[Improvement] Redirect to login page if user doesn't login (#3274)

Co-authored-by: ZhouJinsong <[email protected]> Co-authored-by: baiyangtx <[email protected]> Co-authored-by: ConradJam <[email protected]>
apache · Dec 2, 2024 · b6b1e0f · b6b1e0f
1 parent 604d1c1
commit b6b1e0f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/amoro-web/src/main.ts b/amoro-web/src/main.ts
@@ -71,16 +71,17 @@ RegisterComponents(app);
   finally {
     const store = useStore()
     router.beforeEach((to: RouteLocationNormalized, from: RouteLocationNormalized, next: NavigationGuardNext) => {
-      if (to.fullPath === '/login') {
-        if (store.userInfo.userName) {
-          return next('/')
-        }
+      // if no username in store and not go to login page, should redirect to login page
+      if (!store.userInfo.userName && to.path !== '/login') {
         store.setHistoryPath({
           path: from.path,
-          query: { ...from.query },
+          query: from.query,
         })
+        next('/login')
+      }
+      else {
+        next()
       }
-      next()
     })
 
     app.use(router)

diff --git a/amoro-web/src/views/login/index.vue b/amoro-web/src/views/login/index.vue
@@ -18,7 +18,7 @@ limitations under the License.
 
 <script lang="ts">
 import { message } from 'ant-design-vue'
-import { computed, defineComponent, onMounted, reactive } from 'vue'
+import { computed, defineComponent, reactive } from 'vue'
 import { useRouter } from 'vue-router'
 import loginService from '@/services/login.service'
 import { usePlaceholder } from '@/hooks/usePlaceholder'
@@ -63,7 +63,7 @@ export default defineComponent({
     const disabled = computed(() => {
       return !(formState.username && formState.password)
     })
-    onMounted(() => {})
+
     return {
       placeholder,
       formState,