Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1619] 0.4.x support copy large files when executing full optimizing of Unkeyed Mixed Hive Table #2356

Closed
wants to merge 10 commits into from

Conversation

wangtaohz
Copy link
Contributor

Why are the changes needed?

Close #1619 .

Brief change log

  • optimizers support copy files to new hive locations if all files in this task are large files
  • full optimizing plan of Unkeyed Mixed Hive Table supports split large files and small files into different tasks

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:core Core module module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84cb857) 31.01% compared to head (f1d25da) 52.55%.

Additional details and impacted files
@@              Coverage Diff              @@
##              0.4.x    #2356       +/-   ##
=============================================
+ Coverage     31.01%   52.55%   +21.53%     
+ Complexity     5225      520     -4705     
=============================================
  Files           676       43      -633     
  Lines         62540     3705    -58835     
  Branches       7008      354     -6654     
=============================================
- Hits          19396     1947    -17449     
+ Misses        41400     1625    -39775     
+ Partials       1744      133     -1611     
Flag Coverage Δ
core ?
trino 52.55% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhoujinsong
Copy link
Contributor

@wangtaohz We cannot close the issue as it is not fixed in the master branch yet.

@czy006
Copy link
Contributor

czy006 commented May 17, 2024

This PR has not been merged for a long time, is something stopping it? @zhoujinsong @wangtaohz

Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 22, 2024
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module module:core Core module stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants