Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2888] Can't establish connections when rebooting ams #2889

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

tcodehuber
Copy link
Contributor

Why are the changes needed?

Close #2888.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:build labels May 31, 2024
@tcodehuber tcodehuber requested review from zhoujinsong and hameizi June 7, 2024 01:43
@zhoujinsong
Copy link
Contributor

@tcodehuber Thanks for the contribution!

But I am not sure if allowPublicKeyRetrieval=true is a common property to all MySQL versions.

@tcodehuber
Copy link
Contributor Author

tcodehuber commented Jun 12, 2024

allowPublicKeyRetrieval=true

Although it's imported by mysql8, adding it in the con url will not affect other editions of mysql. It will be ignored if connecting to the mysql below version 8, which will not take side effort. I have tested that in my own env.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.56%. Comparing base (4e3e5c6) to head (3190af3).
Report is 225 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2889      +/-   ##
============================================
+ Coverage     27.47%   27.56%   +0.08%     
  Complexity     2483     2483              
============================================
  Files           360      360              
  Lines         37213    37099     -114     
  Branches       5432     5367      -65     
============================================
+ Hits          10226    10227       +1     
+ Misses        26027    25912     -115     
  Partials        960      960              
Flag Coverage Δ
trino 27.56% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong
Copy link
Contributor

Although it's imported by mysql8, adding it in the con url will not affect other editions of mysql. It will be ignored if connecting to the mysql below version 8, which will not take side effort. I have tested that in my own env.

Thanks for the information.

@zhoujinsong zhoujinsong merged commit 0014cd1 into apache:master Jun 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't establish connections when rebooting ams
3 participants