Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Unlock some configs of the spark optimizer #2950

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

tcodehuber
Copy link
Contributor

Why are the changes needed?

Close #2926, #2927.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Users can add configuration with spark-conf. prefix as needed.

@tcodehuber
Copy link
Contributor Author

LGTM.

Users can add configuration with spark-conf. prefix as needed.

Yes.

@tcodehuber tcodehuber merged commit 345e28b into apache:master Jun 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "spark.driver.userClassPathFirst=true" will cause class conflicts.
2 participants