[AMORO-3118][Improvement]: Move iceberg codes from amoro-core to a new module amoro-iceberg #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:mixed-flink
baiyangtx
force-pushed
the
amoro-core-without-iceberg
branch
3 times, most recently
from
a4bd588 to
e2bee39
Compare
baiyangtx
force-pushed
the
amoro-core-without-iceberg
branch
from
a7b7224 to
faebed7
Compare
baiyangtx
changed the title
baiyangtx
changed the title
baiyangtx
force-pushed
the
amoro-core-without-iceberg
branch
2 times, most recently
from
dc73e22 to
0c13876
Compare
baiyangtx
force-pushed
the
amoro-core-without-iceberg
branch
2 times, most recently
from
b1c81b0 to
acb6f38
Compare
baiyangtx
changed the title
baiyangtx
force-pushed
the
amoro-core-without-iceberg
branch
from
acb6f38 to
bff5939
Compare
zhoujinsong
reviewed
Aug 22, 2024
amoro-ams/amoro-ams-api/src/main/java/org/apache/amoro/api/config/DataExpirationConfig.java
Outdated
Show resolved
Hide resolved
amoro-core/src/main/java/org/apache/amoro/utils/MixedCatalogUtil.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently, there are too many logics related to mixed-format in our amoro-core module.
In order to make amoro to support multiple formats better, amoro needs to have the ability to run without Iceberg.
Therefore, I moved the codes related to mixed-format in
amoro-coreto themixed-formatmodule.In the future, the
amoro-coremodule should focus on the interface definitions across formats.close #3118
Brief change log
I moved all the codes related to mixed-format in
amoro-coreto a new moduleamoro-mixed-format/amoro-mixed-format-core, and only retained some common codes in core, such as those related to Client and UnifiedCatalog.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation