Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-3104] Added table summary metrics #3109

Merged
merged 14 commits into from
Aug 30, 2024
Merged

[AMORO-3104] Added table summary metrics #3109

merged 14 commits into from
Aug 30, 2024

Conversation

MarigWeizhi
Copy link
Contributor

@MarigWeizhi MarigWeizhi commented Aug 17, 2024 •
edited
Loading

Why are the changes needed?

Close #3104.

Brief change log

  • Added TableSummaryMetrics for each table to help users better understand the detail of tables.
  • Changed the structure of OptimizingEvaluator.PendingInput
  • Added a column table_summary to table table_runtime

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added type:docs Improvements or additions to documentation module:ams-server Ams server module labels Aug 17, 2024
@MarigWeizhi MarigWeizhi marked this pull request as draft August 17, 2024 07:57
@MarigWeizhi MarigWeizhi changed the title [AMORO-3104] Added table summary metrics [Draft] [AMORO-3104] Added table summary metrics Aug 17, 2024
@github-actions github-actions bot added module:mixed-spark Spark module for Mixed Format module:core Core module module:mixed-hive Hive moduel for Mixed Format type:infra type:build module:ams-dashboard Ams dashboard module labels Aug 21, 2024
@github-actions github-actions bot removed module:mixed-spark Spark module for Mixed Format module:core Core module module:mixed-hive Hive moduel for Mixed Format type:infra type:build module:ams-dashboard Ams dashboard module labels Aug 21, 2024
@MarigWeizhi MarigWeizhi changed the title [Draft] [AMORO-3104] Added table summary metrics [AMORO-3104] Added table summary metrics Aug 22, 2024
@MarigWeizhi MarigWeizhi marked this pull request as ready for review August 22, 2024 14:28
zhoujinsong
zhoujinsong reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

All changes look good to me except a minor issue.

amoro-ams/amoro-ams-server/src/main/resources/postgres/ams-postgres-init.sql Outdated Show resolved Hide resolved
amoro-ams/amoro-ams-server/src/main/resources/postgres/upgrade.sql Outdated Show resolved Hide resolved
@MarigWeizhi
Copy link
Contributor Author

Thanks for the contribution!

All changes look good to me except a minor issue.

fixed

zhoujinsong
zhoujinsong approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong
Copy link
Contributor

Thanks for the contribution! @MarigWeizhi

@zhoujinsong zhoujinsong merged commit 854f8d4 into apache:master Aug 30, 2024
1 check passed
@zhoujinsong zhoujinsong mentioned this pull request Aug 30, 2024
Merged
3 tasks
@MarigWeizhi MarigWeizhi deleted the metrics branch September 3, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:ams-server Ams server module type:docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add table summary metrics
2 participants
@MarigWeizhi @zhoujinsong