Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-3095][ams-server]Fix: Add s3a dependency software.amazon.awssdk:s3-transfer-manager #3127

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[AMORO-3095][ams-server]Fix: Add s3a dependency software.amazon.awssdk:s3-transfer-manager #3127

merged 1 commit into from
Aug 28, 2024

Conversation

liujie-yt
Copy link
Contributor

@liujie-yt liujie-yt commented Aug 22, 2024 •
edited
Loading

Why are the changes needed?

Close #3095

Brief change log

  • Just add the mvn pom dependency

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate
    When I connect to S3:
    Before:

amoro_class_not_found After: amoro_optimizer amoro_run_success
  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@liujie-yt liujie-yt marked this pull request as ready for review August 23, 2024 01:32
zhoujinsong
zhoujinsong approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit a794592 into apache:master Aug 28, 2024
4 checks passed
@zhoujinsong
Copy link
Contributor

Thanks for the contribution! @liujie-yt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:ams-server Ams server module type:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: ClassNotFoundException: software.amazon.awssdk.transfer.s3.model.ObjectTransfer
2 participants
@liujie-yt @zhoujinsong