Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] k8s helm support using the default Kubernetes client configuration #3250

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[hotfix] k8s helm support using the default Kubernetes client configuration #3250

merged 1 commit into from
Oct 14, 2024

Conversation

czy006
Copy link
Contributor

@czy006 czy006 commented Oct 14, 2024

Why are the changes needed?

Brief change log

  • Helm value.yaml remove kube-config-path value.
  • KubernetesOptimizerContainer Support default Kubernetes client configuration.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible
  • Add screenshots for manual tests if appropriate
  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@czy006 czy006 requested review from baiyangtx and XBaith October 14, 2024 01:56
@github-actions github-actions bot added the module:ams-server Ams server module label Oct 14, 2024
XBaith
XBaith approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@XBaith XBaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong zhoujinsong merged commit d430fe2 into apache:master Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XBaith XBaith XBaith approved these changes

@baiyangtx baiyangtx Awaiting requested review from baiyangtx

Assignees
No one assigned
Labels
module:ams-server Ams server module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czy006 @XBaith @zhoujinsong