-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-3309][Improvement] Support for terminal integration with LDAP authentication in Kyuubi #3309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When LDAP is enabled, how is authentication information passed to Kyuubi?
@Aireed Can you also improve the helm charts? This can make us enable this feature easily. refs: https://github.com/apache/amoro/blob/master/charts/amoro/templates/amoro-configmap.yaml |
I have updated the commition, PTAL. 3ks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3309 +/- ##
============================================
- Coverage 30.17% 30.16% -0.02%
Complexity 3840 3840
============================================
Files 580 580
Lines 48020 48037 +17
Branches 6207 6210 +3
============================================
Hits 14488 14488
- Misses 32542 32559 +17
Partials 990 990
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the contribution! |
Why are the changes needed?
Close #xxx.
Support for terminal integration with LDAP authentication in Kyuubi
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation