Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3309][Improvement] Support for terminal integration with LDAP authentication in Kyuubi #3309

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

Aireed
Copy link
Contributor

@Aireed Aireed commented Oct 29, 2024

Why are the changes needed?

Close #xxx.
Support for terminal integration with LDAP authentication in Kyuubi

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added type:docs Improvements or additions to documentation module:ams-server Ams server module labels Oct 29, 2024
@Aireed Aireed changed the title [Improvement] Support for terminal integration with LDAP authentication in Kyuubi [AMORO-3309][Improvement] Support for terminal integration with LDAP authentication in Kyuubi Oct 29, 2024
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When LDAP is enabled, how is authentication information passed to Kyuubi?

@Aireed
Copy link
Contributor Author

Aireed commented Nov 1, 2024

When LDAP is enabled, how is authentication information passed to Kyuubi?

image

Referring to this configuration manual, you can directly include the username and password in the URL

@tcodehuber
Copy link
Contributor

tcodehuber commented Nov 1, 2024

@Aireed
Copy link
Contributor Author

Aireed commented Nov 4, 2024

@Aireed Can you also improve the helm charts? This can make us enable this feature easily. refs: https://github.com/apache/amoro/blob/master/charts/amoro/templates/amoro-configmap.yaml https://github.com/apache/amoro/blob/master/charts/amoro/values.yaml

I have updated the commition, PTAL. 3ks

Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.16%. Comparing base (f13f3f3) to head (5bf9a66).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../terminal/kyuubi/KyuubiTerminalSessionFactory.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3309      +/-   ##
============================================
- Coverage     30.17%   30.16%   -0.02%     
  Complexity     3840     3840              
============================================
  Files           580      580              
  Lines         48020    48037      +17     
  Branches       6207     6210       +3     
============================================
  Hits          14488    14488              
- Misses        32542    32559      +17     
  Partials        990      990              
Flag Coverage Δ
core 30.16% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhoujinsong zhoujinsong merged commit 549f4b8 into apache:master Nov 5, 2024
5 checks passed
@zhoujinsong
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants