Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3359] only set parallelism on parallelismSourceFunciton #3360

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Aireed
Copy link
Contributor

@Aireed Aireed commented Dec 10, 2024

Why are the changes needed?

Close #3359 .

Brief change log

  • add a filter to check whether the source is a parallelismSourceFunction

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:mixed-flink Flink moduel for Mixed Format label Dec 10, 2024
Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,Does our document need to add this parameter description

@Aireed
Copy link
Contributor Author

Aireed commented Dec 12, 2024

LGTM,Does our document need to add this parameter description

no,

@Aireed Aireed merged commit 6ef1be7 into apache:master Dec 13, 2024
1 check passed
@klion26
Copy link
Member

klion26 commented Dec 14, 2024

Seems after this change has been merged, the CI has failed, could you please help to check if the failed CI is caused by this change thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: throw a exception when set flink task parallelism
3 participants