Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Fix drop database not working in terminal #3363

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[hotfix] Fix drop database not working in terminal #3363

wants to merge 3 commits into from
+33 −3

Conversation

MarigWeizhi
Copy link
Contributor

@MarigWeizhi MarigWeizhi commented Dec 10, 2024 •
edited
Loading

Why are the changes needed?

Close #xxx.

Brief change log

  • Fix drop database not working in terminal

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:mixed-spark Spark module for Mixed Format label Dec 10, 2024
@MarigWeizhi MarigWeizhi changed the title [hotfix] Implement dropNamespace [hotfix] Fix drop database not working in terminal Dec 10, 2024
huyuanfeng2018
huyuanfeng2018 reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@huyuanfeng2018 huyuanfeng2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test to guard against future regression?

@MarigWeizhi
Copy link
Contributor Author

Should we add a test to guard against future regression?

Added test, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyuanfeng2018 huyuanfeng2018 huyuanfeng2018 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
module:mixed-spark Spark module for Mixed Format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarigWeizhi @huyuanfeng2018