Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-3367] Avoid throwing StringIndexOutOfBoundsException in flink optimizer executors #3368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[AMORO-3367] Avoid throwing StringIndexOutOfBoundsException in flink optimizer executors #3368

wants to merge 1 commit into from
+2 −1

Conversation

XBaith
Copy link
Contributor

@XBaith XBaith commented Dec 17, 2024

Why are the changes needed?

Close #3367.

Brief change log

  • Retry the optimization process when a task fails, and handle unexpected errors that occur while extracting error messages.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-optimizer AMS optimizer module label Dec 17, 2024
klion26
klion26 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klion26 klion26 klion26 approved these changes

Assignees
No one assigned
Labels
module:ams-optimizer AMS optimizer module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: StringIndexOutOfBoundsException thrown when intercepting an error message
2 participants
@XBaith @klion26