Write null counts in Parquet statistics when they are known #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arrow-rs into pr/alamb/6257
alamb
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Thank you again @etseidl -- very much appreciated
BTW I think you may be in the bay area -- I am going to be speaking at UC Berkeley in Dec. Feel free to drop me an email at [email protected] if you are interested in meeting face to face.
| @@ -1052,4 +1053,92 @@ mod tests { | |||
| true, | |||
| )); | |||
| } | |||
|
|
|||
| #[test] | |||
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6256
Rationale for this change
Write 0 for null counts in
Statisticswhen they are known, matching behavior of other major Parquet implementations.What changes are included in this PR?
This PR consists of @alamb's changes to
to_thriftforStatisticsfrom #6257, leaving changes tofrom_thriftfor later (as these changes will be breaking).Are there any user-facing changes?
No API changes, but written files will now have
Some(0)fornull_countwhen the count is known to be 0. This increases file sizes by up to 2 bytes perStatisticsobject.