Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatible logic for graphql@16 #2534

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add compatible logic for graphql@16 #2534

wants to merge 4 commits into from
+16 −1

Conversation

m1heng
Copy link

@m1heng m1heng commented Dec 29, 2021

fix #2474

@m1heng m1heng force-pushed the fix/16-compatible branch 2 times, most recently from eb7b1e4 to a8efd47 Compare December 29, 2021 06:28
@m1heng m1heng mentioned this pull request Dec 29, 2021
Closed
capaj
capaj approved these changes Jan 18, 2022
View reviewed changes
Copy link

@capaj capaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please @apollographql can we get this merged?

packages/apollo-graphql/src/schema/buildSchemaFromSDL.ts Outdated Show resolved Hide resolved
@capaj
Copy link

capaj commented Jan 18, 2022

Just FYI this PR blocks: apollographql/federation#1345
which blocks any progress on this: MichalLytek/type-graphql#1100

@hails hails mentioned this pull request Jan 26, 2022
Closed
@Nicoowr
Copy link

Nicoowr commented May 2, 2022

Any news on this? [email protected] uses [email protected] which uses [email protected] which is not compatible with graphql@16 (apollographql/federation#1175)

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3a2cf28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 13, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capaj capaj capaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graphql 16 renamed PossibleTypeExtensions to PossibleTypeExtensionsRule
5 participants
@m1heng @capaj @Nicoowr @mocayo @hwillson