Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev graphql to 16 and add in peerDependency #1345

Closed
wants to merge 5 commits into from

Conversation

m1heng
Copy link

@m1heng m1heng commented Dec 28, 2021

solve #1199

@m1heng m1heng changed the title Update dev graphql to 16 and add 17 in peerDependency Update dev graphql to 16 and add in peerDependency Dec 28, 2021
@m1heng
Copy link
Author

m1heng commented Dec 29, 2021

All test reports "cannot extend type because it is not defined" like error.
Throwing from

let schema = buildSchemaFromSDL(
modules,
new GraphQLSchema({
query: undefined,
directives: [...specifiedDirectives, ...federationDirectives],
}),
);

Input of this function has not changed. So weird.

@m1heng
Copy link
Author

m1heng commented Dec 29, 2021

All test reports "cannot extend type because it is not defined" like error. Throwing from

let schema = buildSchemaFromSDL(
modules,
new GraphQLSchema({
query: undefined,
directives: [...specifiedDirectives, ...federationDirectives],
}),
);

Input of this function has not changed. So weird.

problem located apollographql/apollo-tooling#2474

@m1heng
Copy link
Author

m1heng commented Dec 29, 2021

After manually changed apollo-graphql source code in node_modules locally, all tests passed.
PR for the needed change is made apollographql/apollo-tooling#2534. Once that is merged and released, let's update dependency version here, and everything should be good.

@m1heng
Copy link
Author

m1heng commented Jan 18, 2022

Job done in #1129.

@m1heng m1heng closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant