Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to brainglobe-segmentation #139

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Rename to brainglobe-segmentation #139

merged 5 commits into from
Nov 6, 2023

Conversation

willGraham01
Copy link
Contributor

@willGraham01 willGraham01 commented Nov 1, 2023 •
edited
Loading

Renames the package to brainglobe-segmentation as per brainglobe/BrainGlobe#36.

  • Metadata is updated
  • Internal package references are now consistent
  • Tests have been redirected to the new function/package names

Requires #140 to be merged first, and final version to be published to PyPI.

IMPORTANT

Triggering a release will now upload this package to PyPI and target brainglobe-segmentation rather than brainreg-segment. The SECRETS.API_TOKEN may need updating if it is scoped to the single package.

This means we will loose the ability to push to brainreg-segment after merging this PR! Ensure that brainreg-segment has been tagged marked as deprecated on PyPI first, before merging.

After merging,

  • RENAME this repository to brainglobe-segmentation.
  • Tag version 1.0.0. Publish release notes accordingly.
  • Publish to PyPI by pushing v1.0.0 tag.
  • Update dependencies with the name change:
    • brainreg
    • cellfinder
  • Completion of these steps will then resolve the meta-issue [BGV1] Updates to brainreg-segment BrainGlobe#36

@willGraham01 willGraham01 changed the base branch from main to mark-as-deprecated November 1, 2023 11:13
@willGraham01 willGraham01 mentioned this pull request Nov 1, 2023
Merged
@willGraham01 willGraham01 requested a review from a team November 1, 2023 11:40
@willGraham01 willGraham01 mentioned this pull request Nov 1, 2023
Merged
alessandrofelder
alessandrofelder approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alessandrofelder alessandrofelder mentioned this pull request Nov 2, 2023
Merged
@willGraham01 willGraham01 marked this pull request as ready for review November 6, 2023 09:43
Base automatically changed from mark-as-deprecated to main November 6, 2023 10:33
@willGraham01 willGraham01 merged commit a3d0d0c into main Nov 6, 2023
9 of 10 checks passed
@willGraham01 willGraham01 deleted the bgv1-name-change branch November 6, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willGraham01 @alessandrofelder