Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(8.5): spring sdk oauth scope config #4393

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

megglos
Copy link
Contributor

@megglos megglos commented Oct 4, 2024

Description

Adds ZEEBE_TOKEN_SCOPE env var to sdk config, to make transparent how the client scope can be set with 8.5

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Oct 4, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley added the hold This issue is parked, do not merge. label Oct 4, 2024
@akeller
Copy link
Member

akeller commented Oct 8, 2024

This will be needed for the 8.6.1 patch, will need to be updated once the 8.6 versioned docs are live, do not merge yet.

I don't have any context for this change. When will the 8.6.1 patch go out?

nicpuppa
nicpuppa previously approved these changes Oct 10, 2024
Copy link
Contributor

@nicpuppa nicpuppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this need to be available in 8.6 and 8.6

@akeller
Copy link
Member

akeller commented Oct 10, 2024

The file modified in this PR is for /next or the preview for 8.7.

@megglos megglos added hold This issue is parked, do not merge. and removed hold This issue is parked, do not merge. labels Oct 14, 2024
@akeller akeller mentioned this pull request Oct 16, 2024
9 tasks
@megglos
Copy link
Contributor Author

megglos commented Oct 18, 2024

in the meantime 8.6 was covered with #4473, only 8.5 is open to be included once the next 8.5 patch is released.

@akeller
Copy link
Member

akeller commented Nov 8, 2024

@megglos @nicpuppa, I'm admittedly a bit confused about the status of this PR. Do we need to merge this change for 8.7 (current scope of the PR)? Or just 8.5? If it's just for 8.5, we need to adjust this PR.

@christinaausley
Copy link
Contributor

@megglos @nicpuppa Checking in. Could you please provide a status update for this PR so I can assist if necessary?

@nicpuppa
Copy link
Contributor

nicpuppa commented Dec 9, 2024

@christinaausley I think this property needs to be added in the 8.5 docs, but I'm honestly not sure about it

@megglos
Copy link
Contributor Author

megglos commented Dec 13, 2024

It's not to be included in 8.5 as it wasn't backported in the end (as config implementation changed significantly).

As sdk config changed from 8.5 to 8.6 anyway I would suggest we just add the usage of the ZEEBE_TOKEN_SCOPE env var for the scope to the already listed env vars for 8.5 .

@megglos megglos force-pushed the meg-23071-spring-sdk-oauth-scope branch from 4476889 to 6ce0c6c Compare December 13, 2024 15:22
@megglos megglos changed the title feat: spring sdk oauth scope config feat(8.5): spring sdk oauth scope config Dec 13, 2024
@megglos megglos force-pushed the meg-23071-spring-sdk-oauth-scope branch 3 times, most recently from 7f0ac60 to d3f64b4 Compare December 13, 2024 15:32
@megglos megglos requested a review from nicpuppa December 13, 2024 15:32
@megglos megglos removed the hold This issue is parked, do not merge. label Dec 13, 2024
@megglos megglos force-pushed the meg-23071-spring-sdk-oauth-scope branch from d3f64b4 to 753c3a0 Compare December 13, 2024 16:05
@akeller akeller added the component:zeebe Issues related with Zeebe project label Dec 13, 2024
@akeller akeller merged commit b36629b into main Dec 13, 2024
11 checks passed
@akeller akeller deleted the meg-23071-spring-sdk-oauth-scope branch December 13, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:zeebe Issues related with Zeebe project
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants