Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added scope to properties #4473

Merged
merged 4 commits into from
Oct 17, 2024
Merged

added scope to properties #4473

merged 4 commits into from
Oct 17, 2024

Conversation

jonathanlukas
Copy link
Contributor

Description

This property can be configured, but is undocumented:

https://github.com/camunda/camunda/blob/main/clients/spring-boot-starter-camunda-sdk/src/main/java/io/camunda/zeebe/spring/client/properties/common/ApiProperties.java#L24

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@jonathanlukas jonathanlukas self-assigned this Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@akeller
Copy link
Member

akeller commented Oct 16, 2024

Checking in with the team to see if this will also be available in 8.5 as mentioned via camunda/camunda#23072

@akeller
Copy link
Member

akeller commented Oct 16, 2024

Duplicate of #4393, however they haven't backported that PR.

@jonathanlukas
Copy link
Contributor Author

@akeller well, one of them has to be merged. A customer is missing it.

btw this is required for ms entra integration.

@jonathanlukas
Copy link
Contributor Author

I just filed a PR so that the old place where the scope was added points to the new one: camunda/camunda#23673

Btw the old property is zeebe.client.cloud.scope

@jonathanlukas jonathanlukas merged commit 779936f into main Oct 17, 2024
6 checks passed
@jonathanlukas jonathanlukas deleted the jonathanlukas-patch-2 branch October 17, 2024 13:20
@@ -103,6 +103,7 @@ Example of configuring the connection to a Self-Managed Zeebe cluster:
```properties
zeebe.client.cloud.clientId=your-client-id
zeebe.client.cloud.clientSecret=your-client-secret
zeebe.client.cloud.scope=your-scope # optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not released in 8.5 see the original issue camunda/camunda#23071 . It will be included in the next 8.5 patch.

We need to revert this.

Please always refer to the actual originating issue for context.

Thanks @akeller for the ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants