-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate rocketchip utils to standalone library #3650
base: dev
Are you sure you want to change the base?
Migrate rocketchip utils to standalone library #3650
Conversation
Out of my own ignorance, why do you follow this |
yeah, it's a different directory layout style adopted to reduce dead paths. in mill if you're not defining "SbtModule" as the module type in the build config it defaults to 'millSourcePath / "src"' as opposed to "millSourcePath / src / main / scala" |
What happens if the package needs "resources"? Sbt suggests |
it'll pull from 'millSourcePath/resources' |
I find the mill directory tree much less understandable than the sbt one... This is how I see rocketutils is structured. The standalone diplomacy is structured the same way.
Compared to SBT, where every level of the tree has some useful meaning.
|
Currently i've organized it this way to prep for pulling the source out into it's own repo. as far as hierarchy it's specifically aimed at allowing you to organize around build unit vs around a much more complicated package oriented structure.
it's effectively the same but with way fewer dead levels of hierarchy in the folder structure (which can quickly cause problems with long file names and deep nested structures in some filesystems like ext4) |
Ok I see the motivation. |
yeah, this PR both breaks out the utils package and adds it as a dependency for rocketchip. This should let us make a new repo for the utils stuff and then just move that one folder out and update the build to pull from the new repo. |
Related issue: #3596
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
migrating rocketchip utils to standalone lib