Address more warnings #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
… topic/more-warnings
for more information, see https://pre-commit.ci
… topic/more-warnings
nim65s
previously approved these changes
Jun 30, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… topic/more-warnings
for more information, see https://pre-commit.ci
|
it can't be a patch release, there are breaking changes in devel already. But we can make hpp-fcl v3.0.0 along with coal. Would it work for you ? |
|
Ah, I didn't notice the breaking changes. Can we have another release of hpp-fcl before the renaming or will this have to go together based on the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like quite a few slipped through in #601. May need another iteration or so after this one.