Address more warnings

.github/workflows/ros_ci.yml

@@ -14,14 +14,14 @@ jobs:
           - {ROS_DISTRO: noetic}
           - {ROS_DISTRO: iron}
           - {ROS_DISTRO: humble}
-          #- {ROS_DISTRO: rolling, PRERELEASE: false}  # 2024-04-02: turn off prerelease until Noble is stable; turned off entirely until eigenpy is available
+          #- {ROS_DISTRO: rolling}
     env:
       #CCACHE_DIR: /github/home/.ccache # Enable ccache
       BUILDER: colcon
       PRERELEASE: true
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
       # This step will fetch/store the directory used by ccache before/after the ci run

CHANGELOG.md

@@ -25,7 +25,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Fixed
 
-- Compiler warnings ([#601](https://github.com/humanoid-path-planner/hpp-fcl/pull/601))
+- Compiler warnings ([#601](https://github.com/humanoid-path-planner/hpp-fcl/pull/601), [#605](https://github.com/humanoid-path-planner/hpp-fcl/pull/605))
 - CMake: fix assimp finder
 - Don't define GCC7 Boost serialization hack when `HPP_FCL_SKIP_EIGEN_BOOST_SERIALIZATION` is defined ([#530](https://github.com/humanoid-path-planner/hpp-fcl/pull/530))
 - Default parameters for narrowphase algorithms (GJK and EPA); fixed assertion checks that were sometimes failing in GJK simplex projection and BVH `collide` ([#531](https://github.com/humanoid-path-planner/hpp-fcl/pull/531)).

include/hpp/fcl/fwd.hh

@@ -95,15 +95,24 @@
 #define HPP_FCL_COMPILER_DIAGNOSTIC_POP _Pragma("GCC diagnostic pop")
 #define HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_DEPRECECATED_DECLARATIONS \
   _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"")
+#if !defined(__has_warning) || __has_warning("-Wmaybe-uninitialized")
+#define HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_MAYBE_UNINITIALIZED \
+  _Pragma("GCC diagnostic ignored \"-Wmaybe-uninitialized\"")
+#else
+#define HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_MAYBE_UNINITIALIZED
+#endif
 #elif defined(WIN32)
 #define HPP_FCL_COMPILER_DIAGNOSTIC_PUSH _Pragma("warning(push)")
 #define HPP_FCL_COMPILER_DIAGNOSTIC_POP _Pragma("warning(pop)")
 #define HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_DEPRECECATED_DECLARATIONS \
   _Pragma("warning(disable : 4996)")
+#define HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_MAYBE_UNINITIALIZED \
+  _Pragma("warning(disable : 4700)")
 #else
 #define HPP_FCL_COMPILER_DIAGNOSTIC_PUSH
 #define HPP_FCL_COMPILER_DIAGNOSTIC_POP
 #define HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_DEPRECECATED_DECLARATIONS
+#define HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_MAYBE_UNINITIALIZED
 #endif  // __GNUC__
 
 namespace hpp {

include/hpp/fcl/internal/traversal_node_setup.h

@@ -682,9 +682,14 @@ bool initialize(MeshDistanceTraversalNode<BV, 0>& node,
   node.tri_indices2 =
       model2.tri_indices.get() ? model2.tri_indices->data() : NULL;
 
+  HPP_FCL_COMPILER_DIAGNOSTIC_PUSH
+  HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_MAYBE_UNINITIALIZED
+
   relativeTransform(tf1.getRotation(), tf1.getTranslation(), tf2.getRotation(),
                     tf2.getTranslation(), node.RT.R, node.RT.T);
 
+  HPP_FCL_COMPILER_DIAGNOSTIC_POP
+
   return true;
 }
 

src/narrowphase/support_functions.cpp

@@ -570,13 +570,15 @@ void getShapeSupportSet(const TriangleP* triangle, SupportSet& support_set,
     }
   }
 }
-getShapeSupportSetTplInstantiation(TriangleP);
+// clang-format off
+getShapeSupportSetTplInstantiation(TriangleP)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSet(const Box* box, SupportSet& support_set,
                         int& hint /*unused*/, ShapeSupportData& support_data,
                         size_t /*unused*/, FCL_REAL tol) {
+  // clang-format on
   assert(tol > 0);
   Vec3f support;
   const Vec3f& support_dir = support_set.getNormal();
@@ -612,14 +614,16 @@ void getShapeSupportSet(const Box* box, SupportSet& support_set,
   }
   computeSupportSetConvexHull(polygon, support_set.points());
 }
-getShapeSupportSetTplInstantiation(Box);
+// clang-format off
+getShapeSupportSetTplInstantiation(Box)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSet(const Sphere* sphere, SupportSet& support_set,
                         int& hint /*unused*/,
                         ShapeSupportData& support_data /*unused*/,
                         size_t /*unused*/, FCL_REAL /*unused*/) {
+  // clang-format on
   support_set.points().clear();
 
   Vec3f support;
@@ -628,13 +632,15 @@ void getShapeSupportSet(const Sphere* sphere, SupportSet& support_set,
                                    support_data);
   support_set.addPoint(support);
 }
-getShapeSupportSetTplInstantiation(Sphere);
+// clang-format off
+getShapeSupportSetTplInstantiation(Sphere)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSet(const Ellipsoid* ellipsoid, SupportSet& support_set,
                         int& hint, ShapeSupportData& support_data /*unused*/,
                         size_t /*unused*/, FCL_REAL /*unused*/) {
+  // clang-format on
   support_set.points().clear();
 
   Vec3f support;
@@ -643,14 +649,16 @@ void getShapeSupportSet(const Ellipsoid* ellipsoid, SupportSet& support_set,
                                    support_data);
   support_set.addPoint(support);
 }
-getShapeSupportSetTplInstantiation(Ellipsoid);
+// clang-format off
+getShapeSupportSetTplInstantiation(Ellipsoid)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSet(const Capsule* capsule, SupportSet& support_set,
                         int& hint /*unused*/,
                         ShapeSupportData& support_data /*unused*/,
                         size_t /*unused*/, FCL_REAL tol) {
+  // clang-format on
   assert(tol > 0);
   support_set.points().clear();
 
@@ -686,14 +694,16 @@ void getShapeSupportSet(const Capsule* capsule, SupportSet& support_set,
     }
   }
 }
-getShapeSupportSetTplInstantiation(Capsule);
+// clang-format off
+getShapeSupportSetTplInstantiation(Capsule)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSet(const Cone* cone, SupportSet& support_set,
                         int& hint /*unused*/,
                         ShapeSupportData& support_data /*unused*/,
                         size_t num_sampled_supports, FCL_REAL tol) {
+  // clang-format on
   assert(tol > 0);
   support_set.points().clear();
 
@@ -757,14 +767,16 @@ void getShapeSupportSet(const Cone* cone, SupportSet& support_set,
     }
   }
 }
-getShapeSupportSetTplInstantiation(Cone);
+// clang-format off
+getShapeSupportSetTplInstantiation(Cone)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSet(const Cylinder* cylinder, SupportSet& support_set,
                         int& hint /*unused*/,
                         ShapeSupportData& support_data /*unused*/,
                         size_t num_sampled_supports, FCL_REAL tol) {
+  // clang-format on
   assert(tol > 0);
   support_set.points().clear();
 
@@ -819,14 +831,16 @@ void getShapeSupportSet(const Cylinder* cylinder, SupportSet& support_set,
     }
   }
 }
-getShapeSupportSetTplInstantiation(Cylinder);
+// clang-format off
+getShapeSupportSetTplInstantiation(Cylinder)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSetLinear(const ConvexBase* convex, SupportSet& support_set,
                               int& hint /*unused*/,
                               ShapeSupportData& support_data, size_t /*unused*/,
                               FCL_REAL tol) {
+  // clang-format on
   assert(tol > 0);
   Vec3f support;
   const Vec3f& support_dir = support_set.getNormal();
@@ -943,25 +957,29 @@ void getShapeSupportSet(const ConvexBase* convex, SupportSet& support_set,
         convex, support_set, hint, support_data, num_sampled_supports, tol);
   }
 }
-getShapeSupportSetTplInstantiation(ConvexBase);
+// clang-format off
+getShapeSupportSetTplInstantiation(ConvexBase)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSet(const SmallConvex* convex, SupportSet& support_set,
                         int& hint /*unused*/,
                         ShapeSupportData& support_data /*unused*/,
                         size_t num_sampled_supports /*unused*/, FCL_REAL tol) {
+  // clang-format on
   getShapeSupportSetLinear<_SupportOptions>(
       reinterpret_cast<const ConvexBase*>(convex), support_set, hint,
       support_data, num_sampled_supports, tol);
 }
-getShapeSupportSetTplInstantiation(SmallConvex);
+// clang-format off
+getShapeSupportSetTplInstantiation(SmallConvex)
 
 // ============================================================================
 template <int _SupportOptions>
 void getShapeSupportSet(const LargeConvex* convex, SupportSet& support_set,
                         int& hint, ShapeSupportData& support_data,
                         size_t num_sampled_supports /*unused*/, FCL_REAL tol) {
+  // clang-format on
   getShapeSupportSetLog<_SupportOptions>(
       reinterpret_cast<const ConvexBase*>(convex), support_set, hint,
       support_data, num_sampled_supports, tol);

test/collision.cpp

@@ -43,7 +43,15 @@
 #include <fstream>
 #include <boost/assign/list_of.hpp>
 
+#include <hpp/fcl/fwd.hh>
+
+HPP_FCL_COMPILER_DIAGNOSTIC_PUSH
+HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_DEPRECECATED_DECLARATIONS
+
 #include <hpp/fcl/collision.h>
+
+HPP_FCL_COMPILER_DIAGNOSTIC_POP
+
 #include <hpp/fcl/BV/BV.h>
 #include <hpp/fcl/shape/geometric_shapes.h>
 #include <hpp/fcl/narrowphase/narrowphase.h>
@@ -300,6 +308,9 @@ struct traits<KDOP<N>, Oriented, recursive> : base_traits {
   enum { IS_IMPLEMENTED = false };
 };
 
+HPP_FCL_COMPILER_DIAGNOSTIC_PUSH
+HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_DEPRECECATED_DECLARATIONS
+
 struct mesh_mesh_run_test {
   mesh_mesh_run_test(const std::vector<Transform3f>& _transforms,
                      const CollisionRequest _request)
@@ -319,6 +330,8 @@ struct mesh_mesh_run_test {
 
   int indent;
 
+  HPP_FCL_COMPILER_DIAGNOSTIC_POP
+
   const char* getindent() {
     assert(indent < 9);
     static const char* t[] = {"",
@@ -628,11 +641,16 @@ BOOST_AUTO_TEST_CASE(mesh_mesh) {
             << transforms[i].getQuatRotation().coeffs().format(f));
   }
 
+  HPP_FCL_COMPILER_DIAGNOSTIC_PUSH
+  HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_DEPRECECATED_DECLARATIONS
+
   // Request all contacts and check that all methods give the same result.
   mesh_mesh_run_test runner(
       transforms, CollisionRequest(CONTACT, (size_t)num_max_contacts));
   runner.enable_statistics = true;
   boost::mpl::for_each<BVs_t, wrap<boost::mpl::placeholders::_1> >(runner);
+
+  HPP_FCL_COMPILER_DIAGNOSTIC_POP
 }
 
 BOOST_AUTO_TEST_CASE(mesh_mesh_benchmark) {

test/serialization.cpp

@@ -36,6 +36,11 @@
 #include <fstream>
 #include <boost/test/included/unit_test.hpp>
 
+#include <hpp/fcl/fwd.hh>
+
+HPP_FCL_COMPILER_DIAGNOSTIC_PUSH
+HPP_FCL_COMPILER_DIAGNOSTIC_IGNORED_DEPRECECATED_DECLARATIONS
+
 #include <hpp/fcl/collision.h>
 #include <hpp/fcl/contact_patch.h>
 #include <hpp/fcl/distance.h>
@@ -584,3 +589,5 @@ BOOST_AUTO_TEST_CASE(test_memory_footprint) {
   BOOST_CHECK(static_cast<size_t>(m1.memUsage(false)) ==
               computeMemoryFootprint(m1));
 }
+
+HPP_FCL_COMPILER_DIAGNOSTIC_POP