Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraContainers possibility in deployments #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FernandezBenjamin
Copy link

@FernandezBenjamin FernandezBenjamin commented Feb 3, 2023

Signed-off-by: Benjamin Fernandez [email protected]

Overview
Provide a way to use sidecar container (for example nginx)
This Pull Request is complementary of the pull request on dex app :
dexidp/dex#2266
We are facing an issue with dex which seems to be vulnerable to clickjacking. We would like to get a way to configure the Content Security Policy frame-ancestor context to prevent clickjacking.

What this PR does / why we need it
This PR will permit to put a proxy sidecar container to be able to enables the configuration of the Content-Security policy to prevent clickjacking. By filling sidecar container configuration with the specific fields the application will send csp headers in responses defining the content security policy.
To do so we try to use an nginx sidecar container which work really well with proper headers.

The sidecar container is not required so if the sidecar container is not set the sidecar upgrade in helm charts will not impact other users

Special notes for your reviewer
The most critical endpoints for clickjacking is the /dex/auth one (as a user interaction is needed to provide credential) but by default it is a good point to apply the same policy for all endpoints

Does this PR introduce a user-facing change?
NONE

Checklist

  • Change log updated in Chart.yaml (see the contributing guide for details)
  • Chart version bumped in Chart.yaml (see the contributing guide for details)
  • Documentation regenerated by running make docs

@jkroepke
Copy link
Contributor

jkroepke commented Feb 6, 2023

@FernandezBenjamin does your ingress controller not supporting custom headers through annotations?

@FernandezBenjamin
Copy link
Author

@FernandezBenjamin does your ingress controller not supporting custom headers through annotations?

We doesn't use ingress controller

@FernandezBenjamin
Copy link
Author

FernandezBenjamin commented Mar 23, 2023

Hi team
Is there any chance to get an update about my request ? :)
Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants