Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraContainers possibility in deployments #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/dex/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ maintainers:
annotations:
artifacthub.io/changes: |
- kind: added
description: "Common labels to all resources created by the chart"
description: "Add extra container possibility in deployment chart"
artifacthub.io/images: |
- name: dex
image: ghcr.io/dexidp/dex:v2.35.3
1 change: 1 addition & 0 deletions charts/dex/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ ingress:
| strategy | object | `{}` | Deployment [strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) configuration. |
| networkPolicy.enabled | bool | `false` | Create [Network Policies](https://kubernetes.io/docs/concepts/services-networking/network-policies/) |
| networkPolicy.egressRules | list | `[]` | A list of network policy egress rules |
| extraContainers | list | `[]` | Additionnals container in the pod. See the documentation of [extraContainers](https://github.com/criblio/helm-charts/blob/master/common_docs/EXTRA_EXAMPLES.md#using-extracontainers-) configuration. |

## Migrating from stable/dex (or banzaicloud-stable/dex) chart

Expand Down
3 changes: 3 additions & 0 deletions charts/dex/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ spec:
{{- with .Values.volumeMounts }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.extraContainers }}
{{- toYaml . | nindent 8 }}
{{- end }}
volumes:
- name: config
secret:
Expand Down
15 changes: 15 additions & 0 deletions charts/dex/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -279,3 +279,18 @@ networkPolicy:
# ports:
# - port: 636
# protocol: TCP

# Allow extra containers
extraContainers: []
# Example of nginx sidecar configuration
#- name: dex-sidecar-nginx-proxy
# image: ghcr.io/nginxinc/nginx-unprivileged:1.23.3
# pullPolicy: IfNotPresent
# volumeMounts:
# - mountPath: /etc/nginx
# name: nginx-conf
# readOnly: true
# ports:
# - containerPort: 8443
# name: https-nginx
# protocol: TCP