chore(core): enable eslint/strict-boolean-expressions & strictNullChecks #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1096 +/- ##
==========================================
- Coverage 75.52% 75.50% -0.02%
==========================================
Files 80 80
Lines 16167 16150 -17
Branches 1517 1517
==========================================
- Hits 12210 12194 -16
+ Misses 3918 3917 -1
Partials 39 39
☔ View full report in Codecov by Sentry. |
/home/runner/work/node-wot/node-wot/packages/core/src/helpers.ts Error: 256:50 error Unexpected any value in conditional. An explicit comparison or type cast is required @typescript-eslint/strict-boolean-expressions Note: Locally I do not see this issue!?
JKRhb
approved these changes
Sep 22, 2023
Co-authored-by: Jan Romann <[email protected]>
Co-authored-by: Jan Romann <[email protected]>
Co-authored-by: Jan Romann <[email protected]>
Co-authored-by: Jan Romann <[email protected]>
Co-authored-by: Jan Romann <[email protected]>
Co-authored-by: Jan Romann <[email protected]>
Co-authored-by: Jan Romann <[email protected]>
Co-authored-by: Jan Romann <[email protected]>
Co-authored-by: Jan Romann <[email protected]>
JKRhb
reviewed
Sep 25, 2023
Co-authored-by: Jan Romann <[email protected]>
danielpeintner
commented
Sep 25, 2023
Co-authored-by: Jan Romann <[email protected]>
JKRhb
reviewed
Sep 25, 2023
JKRhb
reviewed
Sep 25, 2023
…github.com/danielpeintner/thingweb.node-wot into issue-1046-strict-boolean-expressions-core
JKRhb
approved these changes
Sep 25, 2023
Co-authored-by: Jan Romann <[email protected]>
|
I was about to approve this, but there is a leftover comment from @JKRhb, to a quick glance I would commit it. Is that ok @danielpeintner? |
Co-authored-by: Jan Romann <[email protected]>
Sorry, I missed that.... I think it is fine now.. |
relu91
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses one checkmark in #1046.