Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): enable eslint/strict-boolean-expressions & strictNullChecks #1096

Merged
merged 21 commits into from
Sep 27, 2023
Merged

chore(core): enable eslint/strict-boolean-expressions & strictNullChecks #1096

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c27de2c
chore(core): enable eslint/strict-boolean-expressions & strictNullChecks
danielpeintner Sep 22, 2023
919518c
fix problem
danielpeintner Sep 22, 2023
e2f5a08
fix remaining problems for consumed-thing.ts
danielpeintner Sep 22, 2023
9ea628b
Update packages/core/src/consumed-thing.ts
danielpeintner Sep 25, 2023
50f06b3
Update packages/core/src/consumed-thing.ts
danielpeintner Sep 25, 2023
994e1a7
refactor: simplification proposed by Jan
danielpeintner Sep 25, 2023
c8dddc8
Update packages/core/src/exposed-thing.ts
danielpeintner Sep 25, 2023
72691c3
Update packages/core/src/exposed-thing.ts
danielpeintner Sep 25, 2023
73fc642
refactor: simplification proposed by Jan
danielpeintner Sep 25, 2023
84949e3
Update packages/core/src/exposed-thing.ts
danielpeintner Sep 25, 2023
532c674
Update packages/core/src/helpers.ts
danielpeintner Sep 25, 2023
f3987b8
Update packages/core/src/protocol-helpers.ts
danielpeintner Sep 25, 2023
6cfe425
Update packages/core/src/protocol-helpers.ts
danielpeintner Sep 25, 2023
ac41e50
Update packages/core/src/wot-impl.ts
danielpeintner Sep 25, 2023
f49175d
Update packages/core/src/exposed-thing.ts
danielpeintner Sep 25, 2023
0f1b2a0
refactor: reverting one step
danielpeintner Sep 25, 2023
ca24f56
Update packages/core/src/consumed-thing.ts
danielpeintner Sep 25, 2023
567fe1e
refactor: simplify
danielpeintner Sep 25, 2023
f5d4f60
Merge branch 'issue-1046-strict-boolean-expressions-core' of https://…
danielpeintner Sep 25, 2023
53d316b
Update packages/core/src/protocol-helpers.ts
danielpeintner Sep 25, 2023
17cb5ce
Update packages/core/src/protocol-helpers.ts
danielpeintner Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/core/src/protocol-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,7 @@
if (
actionName != null &&
uriScheme != null &&
td?.actions != null &&
td.actions[actionName] != null &&
td.actions[actionName].forms != null &&
td?.actions[actionName]?.forms != null &&

Check failure on line 142 in packages/core/src/protocol-helpers.ts

View workflow job for this annotation

GitHub Actions / setup-and-test (ubuntu-latest, 18.x) 

Object is possibly 'undefined'.

Check failure on line 142 in packages/core/src/protocol-helpers.ts

View workflow job for this annotation

GitHub Actions / setup-and-test (ubuntu-latest, 20.x) 

Object is possibly 'undefined'.
JKRhb marked this conversation as resolved.
Show resolved Hide resolved
Array.isArray(td.actions[actionName].forms)
danielpeintner marked this conversation as resolved.
Show resolved Hide resolved
) {
for (const form of td.actions[actionName].forms) {
Expand Down
Loading