-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): add Node.js 22 to matrix #1274
Conversation
|
maybe it fixes Node.js 22 issues
BTW, I created Apollon77/node-mbus#123 |
I messed up mbus with modbus 🙈 |
The new error seems to stem from a wrong node installation!?! https://github.com/eclipse-thingweb/node-wot/actions/runs/8878604576/job/24374716602?pr=1274 |
Seems to be related with nodejs/node#52682 and a possible fix can be found here nodejs/node#52682 (comment) Let's wait a bit. I assume it gets fixed with a new minor version soon. |
Should we go with this suggestion ? |
No longer needed since the GH workflow should pick the latest Node.js 22.x version. Anyhow, we are now running into other issues 😒 Now, I think they are really mbus-related. I will take a closer look next week... |
Created Apollon77/node-mbus#124 |
mbus issue should be resolved (see Apollon77/node-mbus#124 (comment)). We just need to wait till 2.24 is published. |
should fix issue with Node.js 22
We now have some other issues in the step "Test with coverage report" I do not really understand "what" is failing. I just see "passing" or "pending" Anyhow, it fails with |
I am seeing logs like this for Node.js 22
This might be solved by updating AJV. see https://stackoverflow.com/a/77929792 Grr: There are more dependencies: see
OR
Here I am not sure. Is it a "vm2" issue? |
Tested locally and I was able to reproduce the error. All the packages are working correctly but npm run test -w packages/binding-mbus/
> @node-wot/[email protected] test
> mocha --require ts-node/register --extension ts
mbus client test
✔ should override form values with URL
read resource
✔ should throw exception for missing offset
mbus connection test
npm error Lifecycle script `test` failed with error:
npm error Error: command failed
npm error in workspace: @node-wot/[email protected]
npm error at location: E:\Progetti\reluWoT\packages\binding-mbus I don't have that much time to investigate but it is the only package that is falling (you can verify yourself by excluding it by the workspaces list). |
fixes #1273