-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow "var(--" strings as values for all properties #650
base: main
Are you sure you want to change the base?
Conversation
compressed-size: runtime library Size change: +0.00 kB
View unchanged
|
compressed-size: e2e bundles Size change: 0.00 kB View unchanged
|
We need so many FlowFixMe to use this API 🥲 |
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
NOTE: this will be merged after verifying how it affects our code internally. |
Update: The |
What changed / motivation ?
CSS properties are typed in StyleX, and while some properties allow arbitrary strings, many don't. These properties should still permit usages of string referencing CSS variables. The new
StringPrefix<>
type in Flow makes this possible.