Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined behaviour in number serialisation. #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samhocevar
Copy link

When optimising, the compiler is allowed to reorder the read calls
in the following code:

return  (uint16_t)read_uint8_t(info) |
       ((uint16_t)read_uint8_t(info) << 8);

Since read_uint8_t() has side effects, this could read a totally
wrong value and has to be rewritten as such:

uint16_t value = (uint16_t)read_uint8_t(info);
value |= (uint16_t)read_uint8_t(info) << 8;
return value;

This bug has been observed with Visual Studio 2019.

When optimising, the compiler is allowed to reorder the read calls
in the following code:

    return  (uint16_t)read_uint8_t(info) |
           ((uint16_t)read_uint8_t(info) << 8);

Since read_uint8_t() has side effects, this could read a totally
wrong value and has to be rewritten as such:

    uint16_t value = (uint16_t)read_uint8_t(info);
    value |= (uint16_t)read_uint8_t(info) << 8;
    return value;

This bug has been observed with Visual Studio 2019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant