Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined behaviour in number serialisation. #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined behaviour in number serialisation. #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions src/eris.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,28 +639,31 @@ read_uint8_t(Info *info) {

static uint16_t
read_uint16_t(Info *info) {
return (uint16_t)read_uint8_t(info) |
((uint16_t)read_uint8_t(info) << 8);
uint16_t value = (uint16_t)read_uint8_t(info);
value |= (uint16_t)read_uint8_t(info) << 8;
return value;
}

static uint32_t
read_uint32_t(Info *info) {
return (uint32_t)read_uint8_t(info) |
((uint32_t)read_uint8_t(info) << 8) |
((uint32_t)read_uint8_t(info) << 16) |
((uint32_t)read_uint8_t(info) << 24);
uint32_t value = (uint32_t)read_uint8_t(info);
value |= (uint32_t)read_uint8_t(info) << 8;
value |= (uint32_t)read_uint8_t(info) << 16;
value |= (uint32_t)read_uint8_t(info) << 24;
return value;
}

static uint64_t
read_uint64_t(Info *info) {
return (uint64_t)read_uint8_t(info) |
((uint64_t)read_uint8_t(info) << 8) |
((uint64_t)read_uint8_t(info) << 16) |
((uint64_t)read_uint8_t(info) << 24) |
((uint64_t)read_uint8_t(info) << 32) |
((uint64_t)read_uint8_t(info) << 40) |
((uint64_t)read_uint8_t(info) << 48) |
((uint64_t)read_uint8_t(info) << 56);
uint64_t value = (uint64_t)read_uint8_t(info);
value |= (uint64_t)read_uint8_t(info) << 8;
value |= (uint64_t)read_uint8_t(info) << 16;
value |= (uint64_t)read_uint8_t(info) << 24;
value |= (uint64_t)read_uint8_t(info) << 32;
value |= (uint64_t)read_uint8_t(info) << 40;
value |= (uint64_t)read_uint8_t(info) << 48;
value |= (uint64_t)read_uint8_t(info) << 56;
return value;
}

static int16_t
Expand Down