Create new class ParseWithOptions #3730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarolJakubKrawiec
force-pushed
the
parseWithOptions
branch
from
a09decd to
251e95e
Compare
I have added the new parsing methode ParsingOptions to the OpenSource version.
There is a new class called PrasingOptions. With it we can replace old parsing methodes such as keepRawInput or defaultRegion.
I have added the new parsing methode ParsingOptions to the OpenSource version.
There is a new class called PrasingOptions. With it we can replace old parsing methodes such as keepRawInput or defaultRegion.
KarolJakubKrawiec
force-pushed
the
parseWithOptions
branch
from
251e95e to
45cb5e4
Compare
We had to switch up the deprecated test cases of parseAndKeepRawInput and replaced them with parseWithOptions. It includes the phonenumber that has to be parsed and the options such as if the raw input should be kept or what the default regioncode is.
silvio2402
reviewed
Dec 11, 2024
| @@ -2085,7 +2085,7 @@ public void testMaybeExtractCountryCode() { | |||
| public void testParseNationalNumber() throws Exception { | |||
| // National prefix attached. | |||
| assertEquals(NZ_NUMBER, phoneUtil.parse("033316005", RegionCode.NZ)); | |||
| // Some fields are not filled in by parse, but only by parseAndKeepRawInput. | |||
| // Some fields are not filled in by parse, but only by parseWithOptions. | |||
There was a problem hiding this comment.
Can you add " with the keepRawInput option set."?
Comment on lines
21
to
27
| /** | ||
| * Returns the region we are expecting the number to be from. This is ignored if the number being | ||
| * parsed is written in international format. In case of national format, the country_code will be | ||
| * set to the one of this default region. If the number is guaranteed to start with a '+' followed | ||
| * by the country calling code, then RegionCode.ZZ or null can be supplied. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Can you move the javadoc above getDefaultRegion?
Comment on lines
+38
to
+41
| /** | ||
| * Returns whether the raw input should be kept in the PhoneNumber object. If true, the raw_input | ||
| * field and country_code_source fields will be populated. | ||
| */ |
I rewrote some comments because they didnt make sense and were misplaced
In this commit we added the ParsingOptions from the java version which will make parsing in different ways easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new class called ParseWithOptions that should allow for easier use of different methods such as keepRawInput or defaultRegion.