-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new class ParseWithOptions #3730
Open
KarolJakubKrawiec
wants to merge
7
commits into
google:master
Choose a base branch
from
KarolJakubKrawiec:parseWithOptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+321
−95
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ed15e47
Add parsingOptions to OpenSource
KarolJakubKrawiec f5c2748
Create new class ParsingOptions
KarolJakubKrawiec 809f889
Add parsingOptions to OpenSource
KarolJakubKrawiec 45cb5e4
Create new class ParsingOptions
KarolJakubKrawiec 90270c7
Write testcases for parseWithOptions
KarolJakubKrawiec 5155f58
Rewrite comments
KarolJakubKrawiec 9d7975a
Create ParsingOptions for cpp
KarolJakubKrawiec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
58 changes: 58 additions & 0 deletions
58
java/libphonenumber/src/com/google/i18n/phonenumbers/ParsingOptions.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* | ||
* Copyright (C) 2024 The Libphonenumber Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.i18n.phonenumbers; | ||
|
||
/** Options for the phone number parser. */ | ||
public class ParsingOptions { | ||
/** | ||
* Returns the region we are expecting the number to be from. This is ignored if the number being | ||
* parsed is written in international format. In case of national format, the country_code will be | ||
* set to the one of this default region. If the number is guaranteed to start with a '+' followed | ||
* by the country calling code, then RegionCode.ZZ or null can be supplied. | ||
*/ | ||
|
||
private boolean hasDefaultRegion; | ||
private String defaultRegion_ = null; | ||
public boolean hasDefaultRegion() { return hasDefaultRegion; } | ||
public String getDefaultRegion() { return defaultRegion_; } | ||
public ParsingOptions setDefaultRegion(String value) { | ||
hasDefaultRegion = (value != null); | ||
defaultRegion_ = value; | ||
return this; | ||
} | ||
|
||
/** | ||
* Returns whether the raw input should be kept in the PhoneNumber object. If true, the raw_input | ||
* field and country_code_source fields will be populated. | ||
*/ | ||
Comment on lines
+38
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment above. |
||
private boolean hasKeepRawInput; | ||
private boolean keepRawInput_ = false; | ||
public boolean hasKeepRawInput() { return hasKeepRawInput; } | ||
public boolean isKeepRawInput() { return keepRawInput_; } | ||
public ParsingOptions setKeepRawInput(boolean value) { | ||
if(value == false) { | ||
|
||
} | ||
hasKeepRawInput = true; | ||
keepRawInput_ = value; | ||
return this; | ||
} | ||
|
||
public ParsingOptions withDefaultRegion(String regionCode) { | ||
return setDefaultRegion(regionCode); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move the javadoc above
getDefaultRegion
?