-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mpc specific simulation setup #531
Open
Beomyeong
wants to merge
17
commits into
develop
Choose a base branch
from
feature/MPC-specific-simulationsetup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding SCS2AvatarMPCSimulation - Adding SCS2AvatarMPCSimulationFactory - Editing MPC specific classes in NadiaMPCSimulation and NadiaMPCSimulationFactory
…Factory. - Changing the class in NadiaMPCSimulationFactory, SCS2AvatarMPCSimulation and SCS2AvatarMPCSimulationFactory.
- Modifying called class name.
Beomyeong
changed the title
Feature/mpc specific simulation setup
[WIP] Feature/mpc specific simulation setup
Dec 13, 2024
- Adding MPC StepgeneratorThread and task
- wbcc thread is added to the controller. But that thread is still empty, do nothing.
…olTask. - Changing the parents class for MPCControllerTaks, MPCEstimatorTaks, MPCStepGeneratorTask and MPCWholeBodyControllerCoreTask to MPCHumanoidRobotControlTask. - boolean of wholebodycontrollercoreRan is added to HumanoidRobotMPCContextData.
…eBodyControllerCoreManager is called in every tick. - HWBCCM is still empty, so it do nothing.
…lver as parent class. - MPCControllerTask, MPCWholeBodyControllerCoreTask is connected to the MPCCrossRobotCommandResolver. But the MPCEstimatorTask is still connected to the CrossRobotCommandResolver. Because, its updates to Master and to local has not been changes.
- This data type will contain the result of the mpcController and will be delivered to MPCWholeBodyControllerCoreThread from MPCControllerThread
…HumanoidRobotMPCContextData. - In HumanoidWholeBodyControllerCoreManager, the desiredMPCControllerOutput is called and then saved into `desiredJointOutput`which is populated into actuator.
Beomyeong
changed the title
[WIP] Feature/mpc specific simulation setup
Feature/mpc specific simulation setup
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-work for whole body MPC specific simulation environment.
This branch works for two things.
WholeBodyControllerCoreThread
is added.Objectives of this branch are
It seems like robot shaking with the same tuning weighs.
Doubt is that computing MPC in controllerThread and populating it in WBCC Thread.
I hope calculating WBCC with MPC controllerOutput in WBCC thread solves this issue.