-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zh]translate learn/starter,supporter,projects,release/10 & update/translate menu #1950
base: src
Are you sure you want to change the base?
Conversation
Signed-off-by: Eric Poirier <[email protected]>
adding Branding/Why Jakarta to Main Menu translating why-jakarta-ee index page update Chinese Community Supporting list update why-jakarta-ee/table-of-contents with i18n config Signed-off-by: laliwa <[email protected]>
2. edit the Chinese main menu to align with the english version 3. update Chinese Community pages adding Livestream China and Techtalk China new translated articles and new joiners 4. adding i18n setup to community/developer-advocate and Chinese config Signed-off-by: laliwa <[email protected]>
Co-authored-by: Olivier Goulet <[email protected]>
Add Portland JUG
Add Malmö JUG
Update states
Add blog for JCP party
add nashville jug post
Add blog from Seattle
Adds infographic 2023 and refactors infographic's i18n to use params.
Add DWX and GeeCON
Blog from Philly
Add Belgian JUG
Javaforum current
Adds up-to-date videos to the video page via build-time automation
Signed-off-by: Lukas Jungmann <[email protected]> Co-authored-by: Ivar Grimstad <[email protected]>
Add Spring I/O
Add missing past JUG events
Add blog post from Javaforum Malmö
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
update/translate menu Signed-off-by: laliwa <[email protected]>
✅ Deploy Preview for jakartaee ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from some things mentioned below, this PR looks really good!
content/specifications/_index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep these index pages for /specifications.
Same for the ZH and JA locales.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that checking, fix missing files now with this commit 0fa1968
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shortcode has been replaced with layouts/shortcodes/guides_list.html. You shouldn't need to re-add the starter_guides.html shortcode.
This was to make the shortcode more generic to be used for other types of guides such as specification guides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, got that, will notice that in the next commit.
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
translate learn/starter,supporter,projects,release/10
update/translate menu