reuse compilation result of ts-loader #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #107 will improve performances by 12.1%Comparing Summary
Benchmarks breakdown
|
jantimon
commented
Jul 1, 2024
|
I am no longer able to build the playground locally 🤷♂️ @Mad-Kat could you please take a look? |
Mad-Kat
previously approved these changes
Jul 10, 2024
Mad-Kat
previously approved these changes
Jul 10, 2024
Mad-Kat
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now the special import e.g.
./page.yak.module.css!=!./page?./page.yak.module.cssis executed by the css-loader directly from it's original sourcethis means that the typescript transformation has to be run again for the entire code although it was just transformed by the ts-loader
to workaround this issue the compilation result of
./pagecould be reused for./page.yak.module.css!=!./page?./page.yak.module.csssuch a workaround could also help us for
swcas executing swc from the css-loader with the very same options might be tricky