Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix stackblitz #108

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Feature/fix stackblitz #108

merged 1 commit into from
Jul 10, 2024

Conversation

jantimon
Copy link
Owner

@jantimon jantimon commented Jun 30, 2024

follow up for #108

once cssloader does not import tsloader we can switch from mjs to cjs

this might fix a incompatibility with stackblitz (stackblitz/webcontainer-core#1478)

Copy link

vercel bot commented Jun 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-yak-benchmark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:30am
yacijs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:30am

Copy link

codspeed-hq bot commented Jun 30, 2024

CodSpeed Performance Report

Merging #108 will degrade performances by 17.39%

Comparing feature/fix-stackblitz (165f67d) with main (0fc8271)

Summary

❌ 1 (👁 1) regressions
✅ 1 untouched benchmarks

Benchmarks breakdown

Benchmark main feature/fix-stackblitz Change
👁 render KanjiLetterComponentStyled 249.5 ms 302.1 ms -17.39%

Copy link
Collaborator

@Mad-Kat Mad-Kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if the additional files are really needed

packages/next-yak/cssloader.js Show resolved Hide resolved
packages/next-yak/tsloader.js Show resolved Hide resolved
@jantimon jantimon merged commit e607ce7 into main Jul 10, 2024
7 checks passed
@jantimon jantimon deleted the feature/fix-stackblitz branch July 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants