Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H2Data does not support names with ".", "-", or digits #7

Closed
carlosmiranda opened this issue Mar 12, 2014 · 45 comments
Closed

H2Data does not support names with ".", "-", or digits #7

carlosmiranda opened this issue Mar 12, 2014 · 45 comments
Labels
30 mins bug @romankisilenko

Comments

@carlosmiranda
Copy link

I encountered this issue while working on yegor256/s3auth#90.

In S3Auth, the table and attribute names contain . characters, e.g. domain.name. However, H2 does not allow this, but [http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Limits.html](Amazon Dynamo DB) does; Dynamo DB allows - characters and digits 0-9 for table names, and attributes can be any UTF-8 character.

This is something that we should take into account, as other users of this library may also be using names that are not allowed by H2Data but allowed by Dynamo DB.
@yegor256
Copy link
Member

you're right, this is our bug, thanks for reporting

@yegor256
Copy link
Member

@dmarkov please pay for it

@yegor256 yegor256 added the bug label Mar 12, 2014
@carlosmiranda
Copy link
Author

@dmarkov This hasn't been paid for yet.

@yegor256
Copy link
Member

@dmarkov hey, please pay for this report

@dmarkov
Copy link

dmarkov commented Mar 19, 2014

@dmarkov hey, please pay for this report

@yegor256 sorry, but @carlosmiranda is not a member of the team (or I've got wrong information)

@yegor256
Copy link
Member

@dmarkov my bad, now he is, please pay for the report

@dmarkov
Copy link

dmarkov commented Mar 19, 2014

@dmarkov my bad, now he is, please pay for the report

@yegor256 sorry, but @carlosmiranda is not a member of the team (or I've got wrong information)

@carlosmiranda
Copy link
Author

@yegor256 , @dmarkov , will this report be paid for? I'm confused...

@yegor256
Copy link
Member

@dmarkov please pay for this report, I updated project files already

@dmarkov
Copy link

dmarkov commented Mar 24, 2014

@dmarkov please pay for this report, I updated project files already

@yegor256 sorry, but @carlosmiranda is not a member of the team (or I've got wrong information)

@yegor256
Copy link
Member

something is wrong here, I'll check today

@yegor256
Copy link
Member

@dmarkov please try again to pay for this report

@carlosmiranda
Copy link
Author

@dmarkov , @yegor256 , any updates on the payment for this report?

@yegor256
Copy link
Member

yegor256 commented Apr 7, 2014

@dmarkov please pay for this report

@carlosmiranda
Copy link
Author

@dmarkov , @yegor256 , when will this report will be paid for?

@dmarkov
Copy link

dmarkov commented Apr 16, 2014

@dmarkov please try again to pay for this report

@yegor256 yep, done. @carlosmiranda 15 mins was added to your account (payment 38483761), many thanks for your contribution!

@dmarkov
Copy link

dmarkov commented Apr 16, 2014

@dmarkov please pay for this report

@yegor256 sure, it's already done now

@carlosmiranda thanks for your report, I've added 15 mins to your account (ID: 38483764)

@dmarkov
Copy link

dmarkov commented Jul 21, 2014

@hariso it's in your hands now, please proceed

@dmarkov
Copy link

dmarkov commented Sep 5, 2014

@hariso this task is taking too long, I have to change the performer, sorry. Please stop working with it right now. See our no obligations principle

@dmarkov dmarkov removed the @hariso label Sep 5, 2014
@dmarkov
Copy link

dmarkov commented Sep 5, 2014

@antacerod this task is for you, keep these principles in mind, and don't hesitate to ask any technical questions

@dmarkov
Copy link

dmarkov commented Sep 5, 2014

@antacerod Total fixed cost of this task is 30 mins (see this for more info)

@antacerod
Copy link

@dmarkov I have just clone the repo to take a look before accept it.

After launching 'mvn clean install -Pqulice' the build fails. Any missing configuration in my computer about qulice?

...
[INFO] --- maven-failsafe-plugin:2.16:verify (default) @ jcabi-dynamo ---
[INFO] Failsafe report directory: /home/aacevedo/workspaces/teamed/jcabi-dynamo/target/failsafe-reports
[INFO] 
[INFO] --- qulice-maven-plugin:0.8.2:check (jcabi-check) @ jcabi-dynamo ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 59.228s
[INFO] Finished at: Fri Sep 05 18:12:33 CEST 2014
[INFO] Final Memory: 47M/403M
[INFO] ------------------------------------------------------------------------
[ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.lang.NullPointerException
    at org.apache.maven.lifecycle.internal.BuilderCommon.handleBuildError(BuilderCommon.java:128)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:95)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: java.lang.NullPointerException
    at org.codehaus.plexus.component.configurator.converters.composite.CollectionConverter.fromChildren(CollectionConverter.java:157)
    at org.codehaus.plexus.component.configurator.converters.composite.CollectionConverter.fromConfiguration(CollectionConverter.java:112)
    at org.codehaus.plexus.component.configurator.converters.ComponentValueSetter.configure(ComponentValueSetter.java:289)
    at org.codehaus.plexus.component.configurator.converters.composite.ObjectWithFieldsConverter.processConfiguration(ObjectWithFieldsConverter.java:161)
    at org.codehaus.plexus.component.configurator.BasicComponentConfigurator.configureComponent(BasicComponentConfigurator.java:56)
    at org.apache.maven.plugin.internal.DefaultMavenPluginManager.populatePluginFields(DefaultMavenPluginManager.java:567)
    at org.apache.maven.plugin.internal.DefaultMavenPluginManager.getConfiguredMojo(DefaultMavenPluginManager.java:529)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:92)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
    ... 16 more
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/InternalErrorException

@yegor256
Copy link
Member

yegor256 commented Sep 5, 2014

Use Maven 3.1.x or higher. This only happens with Maven 3.0

@antacerod
Copy link

OK.

Then the base64 solution is good.

@yegor256
Copy link
Member

yegor256 commented Sep 6, 2014

My only concern is the maximum length of H2 table name. Try to reproduce extreme cases in unit tests first. Of course, don't forget that we always (!) start with a unit test that reproduces the problem. You may skip the solution (using PDD), but you can't skip the test.

@yegor256
Copy link
Member

yegor256 commented Sep 6, 2014

And base64 includes digits and some other symbols. We need base32

@antacerod
Copy link

Base32 includes the padding character which is not allowed by AWS (http://tools.ietf.org/html/rfc4648#section-6).

Maybe we can change padding characters with underscore characters after Base32 conversion.

@yegor256
Copy link
Member

Yes, sounds good to me

@yegor256
Copy link
Member

@dmarkov assign someone else to this task pls

@dmarkov
Copy link

dmarkov commented Nov 20, 2014

@dmarkov assign someone else to this task pls

@yegor256 all right, we'll find someone else for this task

@dmarkov
Copy link

dmarkov commented Jan 1, 2015

@jenya can you please help? Keep in mind this. If you have any technical questions, don't hesitate to ask right here

This task's budget is 30 mins. This is exactly how much will be paid when the problem explained above is solved. See this for more information

This was referenced Jan 3, 2015
Closed
Closed
@yegor256
Copy link
Member

yegor256 commented Jan 8, 2015

@dmarkov please assign someone else

@dmarkov
Copy link

dmarkov commented Jan 8, 2015

@dmarkov please assign someone else

@yegor256 all right, we'll find someone else for this task

@dmarkov
Copy link

dmarkov commented Jan 8, 2015

@jenya check this "no obligations principle".. This task is on your name for at least 13 days. If you can't close it within the next 16 hours I'll have to assign someone else to it

-30 added to your rating, current score is: -75

@dmarkov
Copy link

dmarkov commented Jan 14, 2015

@RomanKisilenko this task is yours, please help (see our key principles of work). If you have any technical questions, don't hesitate to ask right here... This task's budget is 30 mins. This is exactly how much will be paid when the problem explained above is solved. See this for more information

RomanKisilenko added a commit to RomanKisilenko/jcabi-dynamo that referenced this issue Jan 17, 2015
@RomanKisilenko
jcabi#7 - base32-encode H2 table names to support all possible Dynamo…
616482f 
…DB names
This was referenced Jan 20, 2015
Closed
Merged
RomanKisilenko added a commit to RomanKisilenko/jcabi-dynamo that referenced this issue Jan 21, 2015
@RomanKisilenko
jcabi#7 - get rid of one-time variable
a1ee673
RomanKisilenko added a commit to RomanKisilenko/jcabi-dynamo that referenced this issue Jan 21, 2015
@RomanKisilenko
jcabi#7 - added unit test to check table names with dot and dash char…
2c3756d 
…acters
@RomanKisilenko
Copy link
Contributor

@carlosmiranda The PR was revived and closed. Please close this issue.

@carlosmiranda
Copy link
Author

@RomanKisilenko This has been a long running task, so the resolution is much appreciated! Closing now...

@yegor256
Copy link
Member

@rultor release, tag is 0.18.2

@rultor
Copy link
Contributor

rultor commented Jan 21, 2015

@rultor release, tag is 0.18.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jan 21, 2015

@rultor release, tag is 0.18.2

@yegor256 Done! FYI, the full log is here (took me 12min)

@pinaf pinaf mentioned this issue Jan 22, 2015
Closed
@dmarkov
Copy link

dmarkov commented Jan 23, 2015

@RomanKisilenko Thanks a lot, I just topped your account for 30 mins, transaction ID 50616370

+30 added to your rating, at the moment it is: +360

@pinaf pinaf mentioned this issue Feb 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
30 mins bug @romankisilenko
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@yegor256 @carlosmiranda @RomanKisilenko @antacerod @dmarkov @rultor