feat(cypress): add multiple creds and flags support #6588
+5,618
−4,955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
pixincreate
force-pushed
the
multiple-cred-cypress
branch
from
2dba2c0
to
c4d8809
Compare
pixincreate
commented
Nov 22, 2024
pixincreate
force-pushed
the
multiple-cred-cypress
branch
2 times, most recently
from
d061ad6
to
22feccb
Compare
this is done so that regressions may not arise
this is a huge change! this will make it possible for us to select connector based on the need. say, trustpay refunds only work on a specific connector credential, pass the spec name, done.
…ed-cypress * 'main' of github.com:juspay/hyperswitch: feat(payment_methods_v2): implement a barebones version of list customer payment methods v2 (#6649) ci: update ntid card expiry (#6714) chore(version): 2024.12.02.1 fix(openapi): Revert Standardise API naming scheme for V2 Dashboard Changes (#6712)
jagan-jaya
previously approved these changes
Dec 2, 2024
SanchithHegde
previously approved these changes
Dec 2, 2024
jagan-jaya
previously approved these changes
Dec 2, 2024
14 tasks
| }); | ||
|
|
||
| it("retrieve-payment-call-test", () => { | ||
| cy.retrievePaymentCallTest(globalState); | ||
| const data = getConnectorDetails(globalState.get("connectorId"))[ |
There was a problem hiding this comment.
What is the need of this ?
There was a problem hiding this comment.
glad you asked. data exist only to fetch the Configs and nothing else. in the support/commands.js (image attached below), we're extracting Configs from data. this is done specifically keeping CONNECTOR_CREDENTIAL in mind so that we can pass mca_id directly which is used in verification (assertion check).
the entire field can be removed if we stop doing mca_id check.
There was a problem hiding this comment.
Are we not verifying the payment status ?
There was a problem hiding this comment.
yes. remove this mca_id check?
pixincreate
dismissed stale reviews from jagan-jaya and SanchithHegde
via
172a8d1
pixincreate
requested review from
likhinbopanna,
jagan-jaya and
SanchithHegde
likhinbopanna
approved these changes
Dec 2, 2024
jagan-jaya
approved these changes
Dec 2, 2024
SanchithHegde
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces 2 new features:
closes #6645 (check this issue for detailed documentation / flow / explanation)
Additional Changes
Motivation and Context
How did you test it?
Only Cybersource with
multiple creds(takes only from firstconnector_1):Cybersource with
multiple creds(along withincremental auth):(incremental auth fails from the connector's end and hence 4 failures)
Stripe:
Wise:
PML:
have disabled incremental auth from executing:
trustpay refunds (multiple creds):
i commented iDEAL redirections to check, error is being thrown from connector's end and there's nothing much i can do:
Checklist
prettier . --writecargo clippy