Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Cybersource] change commerce indicator for applepay #6675

Merged

Conversation

Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Change the commerce indicator for cybersource applepay payment which was failing payment in production

Hotfix correspond to PR - #6634

Note: This pr is crucial for flowbird

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested through postman:

  • Create an MCA for Cybersource:
  • Create a Payment with Applepay:
{
    "amount": 650,
    "currency": "USD",
    "confirm": true,
    "amount_to_capture": 650,
    "customer_id": "test_fb",
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "authentication_type": "three_ds",
    "return_url": "https://google.com",
    "email": "[email protected]",
    "name": "Joseph Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "statement_descriptor_name": "Juspay",
    "statement_descriptor_suffix": "Router",
    "payment_method": "wallet",
    "payment_method_type": "apple_pay",
    "payment_method_data": {
        "wallet": {
            "apple_pay": {
                "payment_data": "{{payment_data}}",
                "payment_method": {
                    "display_name": "MasterCard 7599",
                    "network": "MasterCard",
                    "type": "credit"
                },
                "transaction_identifier": "{{transaction_identifier}}"
            }
        },
        "billing": {
            "address": {
                "line1": "jhkdsa",
                "zip": "10000",
                "last_name": "chikke",
                "city": "adf",
                "country": "US",
                "first_name": "srujan",
                "state": "Alabama"
            },
            "email": "[email protected]"
        }
    }
}
  • The payment should succeed

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-bug Category: Bug labels Nov 27, 2024
@Sakilmostak Sakilmostak added this to the November 2024 Release milestone Nov 27, 2024
@Sakilmostak Sakilmostak self-assigned this Nov 27, 2024
@Sakilmostak Sakilmostak requested a review from a team as a code owner November 27, 2024 10:23
Copy link

semanticdiff-com bot commented Nov 27, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/cybersource/transformers.rs  0% smaller

@likhinbopanna likhinbopanna merged commit b397a85 into hotfix-2024.11.20.0 Nov 27, 2024
19 of 23 checks passed
@likhinbopanna likhinbopanna deleted the cybersource_applepay_amex_prodfix branch November 27, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants