Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use renamed script and param for external-domain-tls #259

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Nov 6, 2023

Follow-up for knative/serving#14482

Which issue(s) this PR fixes:
Fixes knative/serving#14369

Copy link

knative-prow bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Nov 6, 2023

/assign @dprotaso

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Nov 6, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
@knative-prow knative-prow bot merged commit d94c0f7 into knative:main Nov 6, 2023
12 checks passed
Copy link

knative-prow bot commented Nov 6, 2023

@ReToCode: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml

In response to this:

Follow-up for knative/serving#14482

Which issue(s) this PR fixes:
Fixes knative/serving#14369

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the aligned flags and certificate secrets in all components
3 participants