-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DuckDuckGo News Search and Video Search #10703
Conversation
web/app/components/base/markdown.tsx
Outdated
@@ -265,7 +265,7 @@ export function Markdown(props: { content: string; className?: string }) { | |||
} | |||
}, | |||
]} | |||
disallowedElements={['script', 'iframe', 'head', 'html', 'meta', 'link', 'style', 'body']} | |||
disallowedElements={['script', 'head', 'html', 'meta', 'link', 'style', 'body']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, I don't think this is a good idea to remove iframe from the markdown for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duckduckgo-video-search feature still works without removing iframe from markdown.tsx.
If keeping iframe, then users will get a video link or a list of video links.
Should I remove the changes in markdown.tsx?
Or can you just ignore the changes in markdown.tsx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please add iframe
back, I shall approve this pr. And please fix the lint errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it back. What's lint errors?
Summary
This PR resolves #10665 (duckduckgo video search)
I also added duckduckgo news search.
Video Search
News Search